Integrating MPS backend #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihming
requested changes
Dec 11, 2023
|
Hi @mbruhns . Thank you very much for your contribution to improving this software. The main part looks good to me. I've left my comments on some minor changes in the review. Please feel free to let me know what you think. Sincerely, |
…space in classifiers in setup.
|
Hi @yihming, what do you think about the changes? |
yihming
reviewed
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for providing this nice Pytorch implementation of Harmony. I slightly adapted the code to make it usable on Apple Silicon. I also updated the requirements to make sure that a suitable Pytorch version is installed. The additional changes are due to reformatting with Ruff and Sourcery. Please let me know if I should adapt anything.