Different decimal lenght for cart and checkout -- first version #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lillik
requested changes
Mar 5, 2021
Model/PricePrecisionConfigTrait.php
Outdated
| return $this->getConfig()->getPricePrecision(); | ||
| //return $context->getLayout(); | ||
| $Val = $this->getConfig()->getPricePrecision(); | ||
| $Val = (strstr($_SERVER['PHP_SELF'], 'checkout') > -1 ) ? $this->getConfig()->getPricePrecisionCheckout() : $Val; |
There was a problem hiding this comment.
I hope to find the proper variable or object to this. Meanwhile, I'm looking for the solution, please accept this way. I don't want to steal your project. I just want to contribute; that's why I don't want nor try to bring users to my fork, but give them as soon as possible a solution ( even if it's not perfect ). During that time, we'll find the proper way to achieve this code perfectly.
| @@ -26,7 +26,11 @@ public function getConfig() | |||
| public function getPricePrecision() | |||
| { | |||
| if ($this->getConfig()->canShowPriceDecimal()) { | |||
| return $this->getConfig()->getPricePrecision(); | |||
| //return $context->getLayout(); | |||
| $Val = $this->getConfig()->getPricePrecision(); | |||
There was a problem hiding this comment.
Please, declare the local variables according to PSR.
README.md
Outdated
| @@ -28,6 +28,8 @@ The preferred way of installing lillik/magento2-price-decimal is through Compose | |||
| php composer.phar require lillik/magento2-price-decimal | |||
| ``` | |||
|
|
|||
| Other way to install: copy all files from here to ./app/code/Lillik/PriceDecimal/ subdirectory ( you'll need to create the directory first). | |||
There was a problem hiding this comment.
Please, define and describe the steps on this way of installation, to be clear for all other developers that choose this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.