-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vz: support .[]networks.vzNAT
networking
#1207
Conversation
Introduces a new YAML property `.[]networks.vzNAT` for enabling `VZNATNetworkDeviceAttachment`. No root privilege is needed. `.[]networks.lima` is reserved for future support of `socket_vmnet` for VZ. Fix issue 1161 Replaces PR 1206 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Looks like the IP is reachable from the host but not from other VZ instances 😞 $ curl 192.168.105.28
curl: (7) Failed to connect to 192.168.105.28 port 80 after 3077 ms: No route to host This issue does not happen with QEMU + |
Is the IP address configurable? |
No. I don't see the API for that. |
I was surprised to get an IP address in the same IP range used for socket_vmnet (on Colima) without any extra configuration i.e. |
That's odd, maybe gvisor-tap-vsock routing it via their interface but even then the host network should be able to access the other guest ip. |
It looks like VZNAT enables |
Support for it is there in private API Reference - https://github.com/Code-Hex/vz/wiki/Private-API-on-macOS-13 Apple might expose it in upcoming versions |
I was able to call using this private API, but interestingly VM crashes when i set it to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the restrictions of vzNAT the changes looks good to me.
Just one point,
Should we also provide a way to get VM IP from limactl ?? I think its not present as of now as well or maybe document ??
|
Ah yes, that should be sufficient 👍 |
I assume this is mergable |
Introduces a new YAML property
.[]networks.vzNAT
for enablingVZNATNetworkDeviceAttachment
. No root privilege is needed..[]networks.lima
is reserved for future support ofsocket_vmnet
for VZ.Fix #1161
Replaces #1206