Fix file URLs with digest #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok that Windows test looks relevant, but possibly a issue with go on windows eg golang/go#51442 I'll see if I can figure out. |
AkihiroSuda
reviewed
Dec 1, 2022
AkihiroSuda
reviewed
Dec 1, 2022
AkihiroSuda
reviewed
Dec 1, 2022
|
Thanks, windows test can be skipped |
pnasrat
force-pushed
the
fix-local-file-download
branch
2 times, most recently
from
eca8535 to
995326e
Compare
AkihiroSuda
reviewed
Jan 9, 2023
| @@ -80,3 +82,37 @@ func TestDownloadRemote(t *testing.T) { | |||
| assert.Equal(t, StatusUsedCache, r.Status) | |||
| }) | |||
| } | |||
|
|
|||
| func TestDownloadLocal(t *testing.T) { | |||
There was a problem hiding this comment.
if runtime.GOOS == "windows" {
// FIXME: `TempDir RemoveAll cleanup: remove C:\users\runner\Temp\TestDownloadLocalwithout_digest2738386858\002\test-file: Sharing violation.`
t.Skip("Skipping on windows")
}There was a problem hiding this comment.
Done. I took a quick look, on how the windows test run via wine and will try figure how to fix/workaround. Sorry for the delay on this PR my end - the end of the year became very busy for me
Fixes lima-vm#1217 Test skipped on windows for now. Signed-off-by: Pris Nasrat <pnasrat@gmail.com>
pnasrat
force-pushed
the
fix-local-file-download
branch
from
995326e to
0e0240e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217
Signed-off-by: Pris Nasrat pnasrat@gmail.com