fix: Allow port forwards to also bind IPv6 addresses #1538
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
Yesterday I hit a weird case in which an application managed to bind to the same port Lima should be using. With the kind help from folks on CNCF's
#lima
Slack channel, I understood that Lima was binding to IPv4, and the other application to IPv6.I confirmed those changes fixed the behaviour on my machines (M1/Intel both running the latest stable macOS version). Also
go test
passes, andmake lint
complains of code unrelated to this PR. However, I'm not really sure how to test those changes further, and couldn't find instructions on how to do so. That said, maintainers, could you kindly take a look and provide further information on how to correctly test those changes?I'll keep this as a draft until we have tests. Thanks!