qemu: use 9p by default #1953

AkihiroSuda · 2023-10-26T14:04:57Z

`qemu: 9p: graduate from experimental`

template://experimental/9p will be removed right before releasing Lima v1.0.

`default.yaml: stop discouraging writable mounts (for 9p and virtiofs)`

Setting writable: true is still discouraged for reverse-sshfs due to
potential connectivity issues, but it should be fine for 9p (virtio-9p-pci)
and virtiofs.

`qemu: use 9p by default`

Templates for the following distro are updated to continue using reverse-sshfs,
as 9p is not available on them.

AlmaLinux
CentOS Stream
Debian
openSUSE
Oracle Linux
Rocky Linux

Warning

Existing instances of the distros above may need running the following command (usually not needed):

limactl edit --mount-type=reverse-sshfs <NAME>

Close #971

TODOs:

Fix issues on Alpine
Parse lima-version file

jandubois

The PR looks fine, but I have concerns about how this seems to break existing instances.

I've created a debian-12 instance with HEAD of master. I started and stopped the instance twice, and it worked fine.

I then switched to this PR branch and tried to start the instance. It hangs with Waiting for the essential requirement 1 of 3: "ssh".

I stopped the instance and modified the mount type with

$ limactl edit --mount-type reverse-sshfs debian-12

Trying to start the instance again, it still hangs with Waiting for the essential requirement 1 of 5: "ssh". The fact that it now list "1 of 5" instead of "1 of 3" shows that the mount type has been set correctly.

I stop once more, and switch back to the master branch. The instance still does not start again.

I realize that this issue exists independently of this PR, but it seems like changing the default can result in permanent damage to an instance. I haven't investigated what might be causing this.

This was on macOS Monterey 12.7.1 on Intel.

I have some other idea about avoiding the automatic change to existing instances, or at least adding a warning when waiting for requirements, but maybe the failure to switch the debian image at all should be resolved first.

examples/experimental/9p.yaml

AkihiroSuda · 2023-10-30T06:00:13Z

avoiding the automatic change to existing instances,

Yes, I wanted to do this, but couldn't figure out how we could implement this

jandubois · 2023-10-30T06:15:39Z

avoiding the automatic change to existing instances,

Yes, I wanted to do this, but couldn't figure out how we could implement this

We can write a lima.version file in the instance directory during limactl create. We look for the file during limactl start. If the file is missing, we assume the version is 0.18.0.

That way we can apply default settings based on the version of Lima used to create the instance.

We never update lima.version; it represents the version used to create the instance, not the version used to run it.

AkihiroSuda · 2024-07-03T05:45:31Z

Can we just rename v0.23 to v1.0?

Yes, I think that is preferable. Working on 2 releases in parallel just increases the risk of introducing regressions.

I just thought you wanted to do a 0.23 release first, as it has a separate milestone on GitHub.

Unified the milestones

jandubois

Thanks, looks good, but I think I would prefer to see something like mountType: not-9p added (better name welcome).

examples/experimental/opensuse-tumbleweed.yaml

pkg/limayaml/defaults.go

AkihiroSuda · 2024-07-24T07:00:07Z

Will rebase after merging:

Use VZ by default for new instances on macOS >= 13.5 #1951

AkihiroSuda · 2024-10-04T06:14:45Z

Rebased and addressed the comments.

Sorry for taking too long for this.

jandubois · 2024-10-07T17:45:18Z

I can't remember why 9p is unsupported in so many distros? Is it just missing packages that we could install (like we install fuse etc), or something more fundamental?

AkihiroSuda · 2024-10-07T17:52:15Z

I can't remember why 9p is unsupported in so many distros?

Because virtiofs is more performant?

Is it just missing packages that we could install (like we install fuse etc), or something more fundamental?

No, needs recompiling the kernel with CONFIG_9P_FS=y or at least with m

AkihiroSuda · 2024-10-07T17:52:58Z

Sorry, accidentally edited #1953 (comment) (now reverted)

AkihiroSuda · 2024-10-07T17:54:31Z

We should eventually entirely switch to virtiofs, when QEMU supports virtiofs on macOS. (Has anybody tried to working on it?)

jandubois

Looks mostly fine, but I have some comments about the code.

Also haven't actually tested it yet, but will try to do so later today.

.github/workflows/test.yml

examples/default.yaml

hack/test-templates/test-misc.yaml

pkg/limayaml/defaults.go

pkg/version/versionutil/versionutil.go

website/content/en/docs/faq/_index.md

examples/default.yaml

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

Setting `writable: true` is still discouraged for reverse-sshfs due to potential connectivity issues, but it should be fine for 9p (virtio-9p-pci) and virtiofs. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

Templates for the following distro are updated to continue using reverse-sshfs, as 9p is not available on them. - AlmaLinux - CentOS Stream - Debian - openSUSE - Oracle Linux - Rocky Linux Close issue 971 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

jandubois

Thanks, LGTM

⚠️ **CAUTION: this is a major update, indicating a breaking change!** ⚠️ This MR contains the following updates: | Package | Update | Change | |---|---|---| | [lima-vm/lima](https://github.com/lima-vm/lima) | major | `v0.23.2` -> `v1.0.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>lima-vm/lima (lima-vm/lima)</summary> ### [`v1.0.2`](https://github.com/lima-vm/lima/releases/tag/v1.0.2) [Compare Source](lima-vm/lima@v1.0.1...v1.0.2) #### Changes - DNS: - Fixed the host resolver regression in v1.0.0 [#2939](lima-vm/lima#2939) ([#2964](lima-vm/lima#2964)) - `limactl create`: - Fixed races during parallel downloads ([#2903](lima-vm/lima#2903), thanks to [@nirs](https://github.com/nirs)) - Optimized qcow2-to-raw conversion for vz mode ([#2933](lima-vm/lima#2933), thanks to [@nirs](https://github.com/nirs)) - `limactl start-at-login`: - Fixed the support for Linux hosts (systemd) ([#2943](lima-vm/lima#2943), thanks to [@kachick](https://github.com/kachick)) - nerdctl: - Updated to [v2.0.1](https://github.com/containerd/nerdctl/releases/tag/v2.0.1) ([#2966](lima-vm/lima#2966)) - Templates: - Updated to the latest revisions ([#2936](lima-vm/lima#2936) [#2953](lima-vm/lima#2953), thanks to [@tcooper](https://github.com/tcooper)) - Web site: - Added an example of running Lima on GitHub Actions to run commands on non-Ubuntu ([#2954](lima-vm/lima#2954)): https://lima-vm.io/docs/examples/gha/ - Project: - Invite Nir Soffer ([@nirs](https://github.com/nirs)) as a Reviewer ([#2916](lima-vm/lima#2916), thanks to [@jandubois](https://github.com/jandubois)) Full changes: https://github.com/lima-vm/lima/milestone/51?closed=1 Thanks to [@SpiffyEight77](https://github.com/SpiffyEight77) [@alexandear](https://github.com/alexandear) [@jandubois](https://github.com/jandubois) [@kachick](https://github.com/kachick) [@nirs](https://github.com/nirs) [@norio-nomura](https://github.com/norio-nomura) [@tamird](https://github.com/tamird) [@tcooper](https://github.com/tcooper) #### Usage ```console [macOS]$ limactl create [macOS]$ limactl start ... INFO[0029] READY. Run `lima` to open the shell. [macOS]$ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/12134682585 The sha256sum of the SHA256SUMS file itself is `02ef78494c498ca4180915ba78d5e2fc471ed401f63dfb2b5864c3711f3c0fb2` . *** Release manager: [@AkihiroSuda](https://github.com/AkihiroSuda) ### [`v1.0.1`](https://github.com/lima-vm/lima/releases/tag/v1.0.1) [Compare Source](lima-vm/lima@v1.0.0...v1.0.1) Reverted the default port forwarder from gRPC to SSH for the stability reason ([#2864](lima-vm/lima#2864)). This reversion fixes several regressions related to `docker run -p` in Lima v1.0.0 ([#2859](lima-vm/lima#2859)). Although the gRPC forwarder is faster and has an advanced feature (UDP support), it turned out to be still immature. Set `LIMA_SSH_PORT_FORWARDER=false` to opt-in to the gRPC forwarder. See <https://lima-vm.io/docs/config/port/>. Full changes: https://github.com/lima-vm/lima/milestone/50?closed=1 Thanks to [@alexandear](https://github.com/alexandear) [@jandubois](https://github.com/jandubois) [@norio-nomura](https://github.com/norio-nomura) #### Usage ```console [macOS]$ limactl create [macOS]$ limactl start ... INFO[0029] READY. Run `lima` to open the shell. [macOS]$ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/11735352652 The sha256sum of the SHA256SUMS file itself is `f5c12d003e25dc46291803a8acae9e9d325a45eca0c1f9f40bd6852ec8ed9be1` . *** Release manager: [@AkihiroSuda](https://github.com/AkihiroSuda) ### [`v1.0.0`](https://github.com/lima-vm/lima/releases/tag/v1.0.0) [Compare Source](lima-vm/lima@v0.23.2...v1.0.0) With the support from 110+ contributors in 3+ years, the Lima project has finally reached v1.0. 🎉 This release introduces several breaking changes, such as switching the default machine driver from QEMU to VZ for better filesystem performance. The `limactl` CLI is designed to print hints when the user hits those breaking changes. e.g., `limactl create template://experimental/vz` now fails with a hint that suggests using `limactl create --vm-type=vz template://default` instead. 🔴 = Major breaking changes 🟡 = Minor breaking changes - VZ: - Graduate VZ machine driver from experimental ([#2758](lima-vm/lima#2758)) - 🔴 Use VZ by default for new instances on macOS >= 13.5 ([#1951](lima-vm/lima#1951)) - Support nested virtualization on M3 ([#2530](lima-vm/lima#2530), thanks to [@abiosoft](https://github.com/abiosoft)) - Optimize qcow2-to-raw image conversion (lima-vm/go-qcow2reader@v0.1.2...v0.4.0 , thanks to [@nirs](https://github.com/nirs)) - Support specifying a custom kernel ([#2562](lima-vm/lima#2562), thanks to [@norio-nomura](https://github.com/norio-nomura)) - QEMU: - Graduate 9p mount driver from experimental ([#2758](lima-vm/lima#2758)) - 🔴 Use 9p by default for most templates ([#1953](lima-vm/lima#1953), [#2822](lima-vm/lima#2822)) - riscv64: switch from u-boot to EDK2 ([#2592](lima-vm/lima#2592)) - Network: - Graduate user-v2 network driver from experimental ([#2758](lima-vm/lima#2758)) - Support UDP port forwarding ([#2411](lima-vm/lima#2411), thanks to [@balajiv113](https://github.com/balajiv113)) - 🔴 Strictly require `socket_vmnet` binary to be owned by root ([#2734](lima-vm/lima#2734)) - SSH: - 🟡 Disable `ssh.loadDotSSHPubKeys` by default ([#2706](lima-vm/lima#2706)) - YAML: - Support generating jsonschema ([#2306](lima-vm/lima#2306), thanks to [@afbjorklund](https://github.com/afbjorklund)) - Support specifying `param` for provisioning scripts ([#2570](lima-vm/lima#2570), thanks to [@jandubois](https://github.com/jandubois)) - Support specifying `minimumLimaVersion` and `vmOpts.qemu.minimumVersion` ([#2659](lima-vm/lima#2659), thanks to [@jandubois](https://github.com/jandubois)) - Support template expansion in mounts ([#2588](lima-vm/lima#2588), thanks to [@norio-nomura](https://github.com/norio-nomura)) - `limactl` CLI: - Add `limactl tunnel` command so as to allow the host to join the guest network ([#2710](lima-vm/lima#2710)) - Add `--log-format=json` ([#2584](lima-vm/lima#2584), thanks to [@nirs](https://github.com/nirs)) - `limactl prune`: Add `--keep-referred` ([#2569](lima-vm/lima#2569), thanks to [@norio-nomura](https://github.com/norio-nomura)) - nerdctl: - Updated to [v2.0.0](https://github.com/containerd/nerdctl/releases/tag/v2.0.0) ([#2178](lima-vm/lima#2178)) - rootless: allocate 1G subuids from 524288 (0x80000) for new users ([#2725](lima-vm/lima#2725)) - Templates: - 🔴 `experimental/vz`: Merged into the `default` template ([#2730](lima-vm/lima#2730), [#2736](lima-vm/lima#2736)) - 🟡 `experimental/{riscv64, armv7l}`: Merged into the `default` template ([#2730](lima-vm/lima#2730), [#2736](lima-vm/lima#2736)) - 🔴 `vmnet`: Removed in favor of `limactl create --network=lima:shared template://default` ([#2736](lima-vm/lima#2736)) - 🟡 `experimental/net-user-v2`: Removed in favor of `limactl create --network=lima:user-v2 template://default` ([#2736](lima-vm/lima#2736)) - 🔴 `experimental/9p`: Removed in favor of `limactl create --mount-type=9p template://default` ([#2736](lima-vm/lima#2736)) - 🟡 `experimental/virtiofs-linux`: Removed in favor of `limactl create --mount-type=virtiofs template://default` ([#2736](lima-vm/lima#2736)) - 🔴 `alpine`: Renamed to `alpine-iso` ([#2704](lima-vm/lima#2704)) - 🔴 `alpine-image`: Renamed to `alpine` ([#2704](lima-vm/lima#2704)) - `archlinux`: Demoted from Tier 1 to Tier 2 ([#2717](lima-vm/lima#2717), [#2823](lima-vm/lima#2823)) - `default`, `ubuntu`, ...: Updated to Ubuntu 24.10. The older versions are available as `ubuntu-20.04`, `ubuntu-22.04`, and `ubuntu-24.04` ([#2755](lima-vm/lima#2755), [#2795](lima-vm/lima#2795)) - `fedora`: Updated to Fedora 41 ([#2821](lima-vm/lima#2821), [#2822](lima-vm/lima#2822), thanks to [@subpop](https://github.com/subpop)) - `opensuse`: Renamed to `opensuse-leap`. Still aliased as `opensuse` ([#2612](lima-vm/lima#2612), thanks to [@afbjorklund](https://github.com/afbjorklund)) - `experimental/opensuse-tumbleweed`: Support aarch64 ([#2613](lima-vm/lima#2613), thanks to [@afbjorklund](https://github.com/afbjorklund)) - `hack/update-template.sh` is added for automating updates ([#1347](lima-vm/lima#1347), thanks to [@norio-nomura](https://github.com/norio-nomura)) - Project: - Invite Norio Nomura ([@norio-nomura](https://github.com/norio-nomura)) as a Reviewer ([#2567](lima-vm/lima#2567)) Full changes: https://github.com/lima-vm/lima/milestone/47?closed=1 Thanks to [@AdamKorcz](https://github.com/AdamKorcz) [@Mr-Sunglasses](https://github.com/Mr-Sunglasses) [@SmartManoj](https://github.com/SmartManoj) [@YorikSar](https://github.com/YorikSar) [@abiosoft](https://github.com/abiosoft) [@afbjorklund](https://github.com/afbjorklund) [@alexandear](https://github.com/alexandear) [@balajiv113](https://github.com/balajiv113) [@hasan4791](https://github.com/hasan4791) [@jandubois](https://github.com/jandubois) [@nirs](https://github.com/nirs) [@norio-nomura](https://github.com/norio-nomura) [@pvdvreede](https://github.com/pvdvreede) [@subpop](https://github.com/subpop) [@tsukasaI](https://github.com/tsukasaI) #### Usage ```console [macOS]$ limactl create [macOS]$ limactl start ... INFO[0029] READY. Run `lima` to open the shell. [macOS]$ lima uname Linux ``` *** The binaries were built automatically on GitHub Actions. The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/11695321667 The sha256sum of the SHA256SUMS file itself is `4bd200a163111fe78c6f3e6de405113d416053802fe1507597f9a42f89a98c90` . *** Release manager: [@AkihiroSuda](https://github.com/AkihiroSuda) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

AkihiroSuda added component/qemu QEMU component/qemu/9p labels Oct 26, 2023

AkihiroSuda added this to the v1.0 (tentative) milestone Oct 26, 2023

AkihiroSuda force-pushed the qemu-9p-default branch from 6071b40 to c0d19c6 Compare October 26, 2023 15:53

AkihiroSuda added the impact/changelog label Oct 26, 2023

AkihiroSuda force-pushed the qemu-9p-default branch 2 times, most recently from ef603e2 to 32316cb Compare October 26, 2023 17:27

AkihiroSuda requested a review from a team October 27, 2023 15:42

AkihiroSuda force-pushed the qemu-9p-default branch from 32316cb to 7cde06d Compare October 27, 2023 16:37

jandubois reviewed Oct 30, 2023

View reviewed changes

examples/experimental/9p.yaml Outdated Show resolved Hide resolved

examples/experimental/9p.yaml Outdated Show resolved Hide resolved

AkihiroSuda marked this pull request as draft October 30, 2023 07:10

jandubois mentioned this pull request Dec 22, 2023

Set guest timezone from host setting #2097

Merged

jandubois mentioned this pull request Jan 1, 2024

Store Lima version in the instance directory #2107

Merged

AkihiroSuda force-pushed the qemu-9p-default branch 2 times, most recently from 1deedf3 to 8c9aceb Compare July 1, 2024 05:44

This comment was marked as resolved.

Sign in to view

AkihiroSuda force-pushed the qemu-9p-default branch 5 times, most recently from 3434ee7 to 2b8d352 Compare July 2, 2024 07:36

AkihiroSuda marked this pull request as ready for review July 2, 2024 07:36

AkihiroSuda requested a review from jandubois July 2, 2024 07:37

AkihiroSuda force-pushed the qemu-9p-default branch from 2b8d352 to a566f72 Compare July 2, 2024 07:38

This was referenced Jul 2, 2024

boot/04-persistent-data-volume.sh: fix 9p cache options #2460

Merged

pkg/store: split pkg/version/versionutil #2461

Merged

AkihiroSuda force-pushed the qemu-9p-default branch from a566f72 to ddd0bf5 Compare July 3, 2024 05:29

AkihiroSuda force-pushed the qemu-9p-default branch from ddd0bf5 to 81b2bd5 Compare July 16, 2024 05:17

jandubois previously approved these changes Jul 19, 2024

View reviewed changes

AkihiroSuda marked this pull request as draft July 24, 2024 07:15

AkihiroSuda modified the milestones: v0.22.1, v1.0 Jul 25, 2024

AkihiroSuda dismissed jandubois’s stale review via 47565ec October 4, 2024 06:13

AkihiroSuda force-pushed the qemu-9p-default branch from 81b2bd5 to 47565ec Compare October 4, 2024 06:13

AkihiroSuda marked this pull request as ready for review October 4, 2024 06:14

This comment was marked as resolved.

Sign in to view

AkihiroSuda force-pushed the qemu-9p-default branch 3 times, most recently from 28f2d2e to 88cca75 Compare October 4, 2024 08:51

AkihiroSuda requested review from jandubois and a team October 4, 2024 09:35

jandubois requested changes Oct 7, 2024

View reviewed changes

jandubois reviewed Oct 7, 2024

View reviewed changes

examples/default.yaml Outdated Show resolved Hide resolved

AkihiroSuda added 3 commits October 8, 2024 16:18

qemu: 9p: graduate from experimental

75d79f5

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>

AkihiroSuda force-pushed the qemu-9p-default branch from 88cca75 to 8d217c4 Compare October 8, 2024 07:37

jandubois approved these changes Oct 8, 2024

View reviewed changes

jandubois merged commit 08b597f into lima-vm:master Oct 8, 2024
27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qemu: use 9p by default #1953

qemu: use 9p by default #1953

AkihiroSuda commented Oct 26, 2023 •

edited

Loading

jandubois left a comment •

edited

Loading

AkihiroSuda commented Oct 30, 2023

jandubois commented Oct 30, 2023

This comment was marked as resolved.

This comment was marked as resolved.

AkihiroSuda commented Jul 3, 2024

jandubois left a comment

AkihiroSuda commented Jul 24, 2024

AkihiroSuda commented Oct 4, 2024

This comment was marked as resolved.

jandubois commented Oct 7, 2024 •

edited by AkihiroSuda

Loading

AkihiroSuda commented Oct 7, 2024

AkihiroSuda commented Oct 7, 2024

AkihiroSuda commented Oct 7, 2024

jandubois left a comment

jandubois left a comment

qemu: use 9p by default #1953

qemu: use 9p by default #1953

Conversation

AkihiroSuda commented Oct 26, 2023 • edited Loading

qemu: 9p: graduate from experimental

default.yaml: stop discouraging writable mounts (for 9p and virtiofs)

qemu: use 9p by default

jandubois left a comment • edited Loading

Choose a reason for hiding this comment

AkihiroSuda commented Oct 30, 2023

jandubois commented Oct 30, 2023

This comment was marked as resolved.

This comment was marked as resolved.

AkihiroSuda commented Jul 3, 2024

jandubois left a comment

Choose a reason for hiding this comment

AkihiroSuda commented Jul 24, 2024

AkihiroSuda commented Oct 4, 2024

This comment was marked as resolved.

jandubois commented Oct 7, 2024 • edited by AkihiroSuda Loading

AkihiroSuda commented Oct 7, 2024

AkihiroSuda commented Oct 7, 2024

AkihiroSuda commented Oct 7, 2024

jandubois left a comment

Choose a reason for hiding this comment

jandubois left a comment

Choose a reason for hiding this comment

AkihiroSuda commented Oct 26, 2023 •

edited

Loading

`qemu: 9p: graduate from experimental`

`default.yaml: stop discouraging writable mounts (for 9p and virtiofs)`

`qemu: use 9p by default`

jandubois left a comment •

edited

Loading

jandubois commented Oct 7, 2024 •

edited by AkihiroSuda

Loading