Generate cloud-config outside of cidata.iso too #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
force-pushed
the
cloud-config
branch
from
17ec2bd
to
287b070
Compare
afbjorklund
force-pushed
the
cloud-config
branch
from
6cc4b39
to
84b1da2
Compare
afbjorklund
force-pushed
the
cloud-config
branch
from
84b1da2
to
8ee410c
Compare
AkihiroSuda
reviewed
Jun 30, 2024
|
Note for testing, it is possible to extract the user-data of a started instance: You could also mount the CD and copy the The new file is in |
AkihiroSuda
reviewed
Jul 2, 2024
AkihiroSuda
reviewed
Jul 2, 2024
afbjorklund
force-pushed
the
cloud-config
branch
3 times, most recently
from
10b182f
to
89b92e3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
afbjorklund
force-pushed
the
cloud-config
branch
from
89b92e3
to
c1fa294
Compare
afbjorklund
force-pushed
the
cloud-config
branch
2 times, most recently
from
dc1c3e3
to
8fee921
Compare
afbjorklund
force-pushed
the
cloud-config
branch
from
8fee921
to
f80c5d7
Compare
AkihiroSuda
reviewed
Oct 7, 2024
AkihiroSuda
reviewed
Oct 9, 2024
afbjorklund
force-pushed
the
cloud-config
branch
from
d2145b6
to
f80c5d7
Compare
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
This does not include any mounts, networks, nor boot scripts. It is assumed that "reverse-sshfs" is being used, for mounts. It also does not include lima-guestagent, nerdctl-full.tgz, or any of the provisioning scripts that are in the cidata... Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
It was already generated by "create", but it might have changed since. So make sure that it is updated by "start". It is up to the user if they already used this file, and if so they need to update the file for the next boot too. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Since it is a pointer, it is always true (non-nil). And structs are always true, so they can't be tested. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
force-pushed
the
cloud-config
branch
from
f80c5d7
to
4b3a0fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2268