Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: remove sidebar search box and enhance the one in the top navigation bar #3064

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

paulinek13
Copy link

Hi!

I’d like to make a small contribution to Lima :)

Overview

I have updated the _variables_project.scss file to unify the styling of the search boxes, following the recent addition of local search powered by Lunr.

Benefits

These changes enhance visual consistency and accessibility.

Visual Comparison

Below is before-and-after comparison to showcase the improvements.

The homepage:
comparison

/docs after the changes:
new


Thank you for considering this contribution. I look forward to your feedback :)

Unify the coloring of the search boxes in the sidebar and the navigation bar.
Update the icon color to the secondary color to create an accent effect.

Signed-off-by: Paulina Kalicka <71526180+paulinek13@users.noreply.github.com>
@AkihiroSuda
Copy link
Member

Can we rather remove one of them?
I don't think the page should have two search boxes

Signed-off-by: Paulina Kalicka <71526180+paulinek13@users.noreply.github.com>
@paulinek13 paulinek13 changed the title website: unify and enhance styling of search boxes website: remove sidebar search box and enhance the one in the top navigation bar Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants