Skip to content

go.mod: clean up gomodjail comments #3260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

AkihiroSuda
Copy link
Member

Before:

module github.com/lima-vm/lima

require (
  github.com/Code-Hex/go-infinity-channel v1.0.0 // indirect; indirect //
gomodjail:confined
  github.com/fsnotify/fsnotify v1.8.0 // indirect
)

After:

// gomodjail:confined
module github.com/lima-vm/lima

require (
  github.com/Code-Hex/go-infinity-channel v1.0.0 // indirect
  // gomodjail:unconfined
  github.com/fsnotify/fsnotify v1.8.0 // indirect
)

The old syntax was causing issues with Dependabot.

Fix #3256

Before:

```go-module
module github.com/lima-vm/lima

require (
  github.com/Code-Hex/go-infinity-channel v1.0.0 // indirect; indirect //
gomodjail:confined
  github.com/fsnotify/fsnotify v1.8.0 // indirect
)
```

After:

```go-module
// gomodjail:confined
module github.com/lima-vm/lima

require (
  github.com/Code-Hex/go-infinity-channel v1.0.0 // indirect
  // gomodjail:unconfined
  github.com/fsnotify/fsnotify v1.8.0 // indirect
)
```

The old syntax was causing issues with Dependabot.

Fix issue 3256

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda added this to the v1.1 (tentative) milestone Feb 18, 2025
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit b55086f into lima-vm:master Feb 18, 2025
31 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Mar 25, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [lima-vm/lima](https://github.com/lima-vm/lima) | patch | `v1.0.6` -> `v1.0.7` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>lima-vm/lima (lima-vm/lima)</summary>

### [`v1.0.7`](https://github.com/lima-vm/lima/releases/tag/v1.0.7)

[Compare Source](lima-vm/lima@v1.0.6...v1.0.7)

#### Changes

-   nerdctl: update to v2.0.4 ([#&#8203;3373](lima-vm/lima#3373))
-   WSL2: lots of improvements (several MRs, thanks to [@&#8203;arixmkii](https://github.com/arixmkii))
-   Makefile: allow setting `KEEP_SYMBOLS=1` ([#&#8203;3236](lima-vm/lima#3236))
-   go.mod: experimental integration of [gomodjail](https://github.com/AkihiroSuda/gomodjail) (library sandbox) ([#&#8203;3238](lima-vm/lima#3238), [#&#8203;3260](lima-vm/lima#3260))

Full changes: https://github.com/lima-vm/lima/milestone/57?closed=1

Thanks to [@&#8203;alexandear](https://github.com/alexandear) [@&#8203;arixmkii](https://github.com/arixmkii) [@&#8203;jandubois](https://github.com/jandubois) [@&#8203;kairveeehh](https://github.com/kairveeehh) [@&#8203;mook-as](https://github.com/mook-as) [@&#8203;rfay](https://github.com/rfay)

#### Usage

```console
[macOS]$ limactl create
[macOS]$ limactl start
...
INFO[0029] READY. Run `lima` to open the shell.

[macOS]$ lima uname
Linux
```

***

The binaries were built automatically on GitHub Actions.
The build log is available for 90 days: https://github.com/lima-vm/lima/actions/runs/14009229801

The sha256sum of the SHA256SUMS file itself is `59f4e8a5b40e6477849ac2dc343b33c9b1c30538516ef44530873d401da7e646` .

***

Release manager: [@&#8203;AkihiroSuda](https://github.com/AkihiroSuda)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4yMTIuMiIsInVwZGF0ZWRJblZlciI6IjM5LjIxMi4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod: apply gomodjail:confined to the global scope
2 participants