fix: ensure usrlocalsharelima.Dir() works when called from tests #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement VM plugin subsystem
Added README.md for Lima VM Plugin Subsystem Contribution - Documented the VM Plugin Subsystem implementation, highlighting the decoupling of VM drivers (`qemu`, `vz`, `wsl2`) via gRPC. - Provided details on the gRPC interface, plugin framework, and driver migration. - Addressed test failures from the main Lima repo, inviting maintainers to review and collaborate on improvements. - Introduced myself as a newcomer to open source, emphasizing my eagerness to learn and contribute. This README aims to provide CNCF Lima mentors and contributors with a clear understanding of my work and request for feedback.
|
There is something wrong with this PR; it adds almost 2000 lines, many unrelated to the issue it is supposed to fix. This may be responsible for the various test failures. Don't merge Please squash commits into a single commit and add a DCO signature. Thanks! |
@Konikz Are you planning to fix this PR? There is nothing we can do with it until the extraneous commits are removed and the lint failures addressed. |
|
@jandubois I'll rectify the issue with the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3208
During tests,
usrlocalsharelima.Dir()fails to find the guestagent binary because the test executable is in a temp directory. This PR adds a test that verifies the binary can be found in both expected locations:share/limadirectory relative to the test executableThe test creates dummy binaries in both locations and verifies
Dir()can find them. This ensures the function works correctly in test environments whereos.Executablereturns a temp directory path.