pkg/hostagent/requirements.go: Avoid command substitution when creating pipe inputs on executing requirements #4279
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng pipe inputs on executing requirements I hope this change can avoid error `stderr="\"\": read |0: bad file descriptor"`. An example log in CI: https://github.com/lima-vm/lima/actions/runs/19009478793/job/54288264005?pr=4275#step:10:206 > {"time":"2025-11-02T08:20:01.457239Z","status":{"running":true,"degraded":true,"errors":["failed to satisfy the optional requirement 1 of 2 \"systemd must be available\": systemd is required to run containerd, but does not seem to be available.\nMake sure that you use an image that supports systemd. If you do not want to run\ncontainerd, please make sure that both 'container.system' and 'containerd.user'\nare set to 'false' in the config file.\n; skipping further checks: stdout=\"\", stderr=\"\": failed to execute script \"systemd must be available\": stdout=\"\", stderr=\"\": read |0: bad file descriptor"],"sshLocalPort":49262}} This error is speculated to occur because the stdin is closed before the EOF is detected when `read` reads stdin. This change tries to reduce the possibility of stdin being closed by separating command substitution from the process of creating stdin to `read`. Signed-off-by: Norio Nomura <norio.nomura@gmail.com>
|
Thanks! 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this change can avoid error
stderr="\"\": read |0: bad file descriptor".An example log in CI:
https://github.com/lima-vm/lima/actions/runs/19009478793/job/54288264005?pr=4275#step:10:206
This error is speculated to occur because the stdin is closed before the EOF is detected when
readreads stdin. This change tries to reduce the possibility of stdin being closed by separating command substitution from the process of creating stdin toread.