Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guestagent: run as the root #72

Closed
wants to merge 1 commit into from
Closed

Conversation

AkihiroSuda
Copy link
Member

The guestagent will soon require root privileges (mostly for virtio stuff), so the guestagent will have to run as the root.

The guestagent will soon require root privileges (mostly for virtio stuff),
so the guestagent will have to run as the root.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda marked this pull request as ready for review June 22, 2021 12:56
@AkihiroSuda AkihiroSuda marked this pull request as draft June 23, 2021 07:56
@AkihiroSuda
Copy link
Member Author

virtserial turned out to be slower than ssh (#20 (comment)), so I'm not likely to implement virtserial soon, and probably I don't need to run the guestagent as the root.

So I'm withdrawing this PR, but I can reopen if this is beneficial for Alpine.

cc @jandubois

@jandubois
Copy link
Member

I can reopen if this is beneficial for Alpine.

The only reason it would have been needed was to implement lima-guestagent install-openrc, but I think creating the openrc script in the cloud-init data is more straight-forward, so wouldn't want to change it.

@AkihiroSuda AkihiroSuda deleted the dev-guestagent-as-root branch October 5, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants