Document the default option for video.display #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jul 25, 2022
| # As of QEMU v6.2, enabling this is known to have negative impact | ||
| # on performance on macOS hosts: https://gitlab.com/qemu-project/qemu/-/issues/334 | ||
| # Choosing "none" will hide the video output, and not show any window. | ||
| # Choosing "default" will pick the first available of: gtk, sdl, cocoa. |
Member
There was a problem hiding this comment.
It should be noted that this is the default value of QEMU, not Lima
Member
Author
There was a problem hiding this comment.
Hmm, that was supposed to be on the line directly below that one.
# 🟢 Builtin default: "none"
Member
There was a problem hiding this comment.
I guess that are confusing to new comers and need explicit explanation
Member
Author
There was a problem hiding this comment.
Maybe it would be less confusing, if all five alternatives were explained ?
Member
Author
There was a problem hiding this comment.
Perhaps if the text is not close to the other one, it would be better ? Flipped them...
AkihiroSuda
added
documentation
Useful for writing cross-platform yaml files. But is not a new display type, or anything... Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
force-pushed
the
display-default
branch
from
129eec4 to
de13d04
Compare
AkihiroSuda
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for writing cross-platform yaml files:
But is not a new display type, or anything...