Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

vde_switch consistent program path #35

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

flyinprogrammer
Copy link
Contributor

i believe these were missed in this commit: b3c2d6a

maybe? while trying to troubleshoot why these services won't start on my machine it seemed like a minor thing to fix 🤷

Signed-off-by: Alan Scherger <flyinprogrammer@gmail.com>
@jandubois
Copy link
Member

i believe these were missed in this commit: b3c2d6a

I think they were rather re-introduced in 55799ca, but anyways, good catch!

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda
Copy link
Member

(Why didn't we catch this in CI?)

@AkihiroSuda AkihiroSuda merged commit 4659448 into lima-vm:master Feb 2, 2022
@jandubois
Copy link
Member

(Why didn't we catch this in CI?)

Not sure. But probably because we do brew install qemu, which depends on the vde package, which will install /usr/local/bin/vde_switch. That means the launch daemon may have been failing initially but can now restart successfully and the following test succeeds.

Which means the CI test would have been running against the homebrew version of vde_switch and not against the one we built and installed.

Not 100% sure this is what happened, but seems plausible to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants