Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong EmailHeader type definition #63

Merged
merged 4 commits into from
Jun 14, 2022
Merged

fix wrong EmailHeader type definition #63

merged 4 commits into from
Jun 14, 2022

Conversation

qyb
Copy link
Contributor

@qyb qyb commented Jun 12, 2022

No description provided.

chibenwa
chibenwa previously approved these changes Jun 12, 2022
Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution ;-)

For me that is good as it is but adding a test would be even better.

Regards

src/types.ts Outdated Show resolved Hide resolved
@qyb
Copy link
Contributor Author

qyb commented Jun 12, 2022

Thanks for the contribution ;-)

For me that is good as it is but adding a test would be even better.

Regards

Which JMAP server are you using? Recently I began to implement webmail for cyrus-imapd (demo: https://bwh1.rubyfish.app/ ). I found some limitations when I try jmap-client-ts. I want to put my patch into the mainstream in the following days.

@chibenwa
Copy link
Member

Which JMAP server are you using?

We are using Apache James https://james.apache.org/

I found some limitations when I try jmap-client-ts. I want to put my patch into the mainstream in the following days.

I would be interested to know wich ones.

Of course this library should have support for Cyrus too and your patches are more than welcome.

@qyb
Copy link
Contributor Author

qyb commented Jun 13, 2022

Which JMAP server are you using?

We are using Apache James https://james.apache.org/

I found some limitations when I try jmap-client-ts. I want to put my patch into the mainstream in the following days.

I would be interested to know wich ones.

Of course this library should have support for Cyrus too and your patches are more than welcome.

I noticed CONTRIBUTING.md just a minute ago. I'll try the docker image & test suite.

@alagane
Copy link
Member

alagane commented Jun 13, 2022

Hi, thanks for your contribution.
Looks good to me, I checked the specs and it is ok, you just have to apply the modification @chibenwa suggested (either by committing it or by force-pushing it).

@alagane alagane merged commit e55de94 into linagora:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants