Introduce the CalendarEventAttendance/get JMAP method #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Jan 8, 2025
| import org.apache.james.utils.DataProbeImpl | ||
| import org.junit.jupiter.api.{BeforeEach, Test} | ||
|
|
||
| trait LinagoraCalendarEventAttendanceGetMethodContract { |
There was a problem hiding this comment.
Please test edge cases:
- invalid blob
- blob is not an ICS
- missing capability
- etc...
chibenwa
reviewed
Jan 8, 2025
...s/src/test/scala/com/linagora/tmail/james/jmap/StandaloneEventAttendanceRepositoryTest.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Jan 8, 2025
Arsnael
reviewed
Jan 9, 2025
chibenwa
reviewed
Jan 9, 2025
...scala/com/linagora/tmail/james/common/LinagoraCalendarEventAttendanceGetMethodContract.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Jan 9, 2025
...scala/com/linagora/tmail/james/common/LinagoraCalendarEventAttendanceGetMethodContract.scala
Outdated
Show resolved
Hide resolved
chibenwa
approved these changes
Jan 9, 2025
|
Now, the dav version with module chooser :-) |
|
Please clean up commit history and add the issue as a prefix on commit descriptions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1328
TODO