Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-1155 Change input suggestion field for fields "From"/"To" in advance search #2288

Merged
merged 14 commits into from
Nov 9, 2023
Merged

TF-1155 Change input suggestion field for fields "From"/"To" in advance search #2288

merged 14 commits into from
Nov 9, 2023

Conversation

hieutbui
Copy link
Member

@hieutbui hieutbui commented Oct 24, 2023 •
edited
Loading

Issue

#1155

Resolved

TF-1155.demo.mp4

@hieutbui hieutbui temporarily deployed to PR-2288 October 24, 2023 17:19 — with GitHub Actions Inactive
@github-actions
Copy link

This PR has been deployed to https://linagora.github.io/tmail-flutter/2288.

@hieutbui hieutbui force-pushed the improvement/TF-1155-Change-weight-of-input-field-in-advance-search branch from cf87300 to cca9c9c Compare October 25, 2023 01:57
@hieutbui hieutbui temporarily deployed to PR-2288 October 25, 2023 01:57 — with GitHub Actions Inactive
@hieutbui hieutbui requested review from dab246 and hoangdat October 25, 2023 02:18
@hoangdat
Copy link
Member

  • IMO, we need to apply the same behavior with to in composer

@hieutbui hieutbui force-pushed the improvement/TF-1155-Change-weight-of-input-field-in-advance-search branch from cca9c9c to a27d8fd Compare October 30, 2023 04:09
@hieutbui hieutbui changed the title TF-1155 Change input field weight for fields "From"/"To" in advance search [WIP] TF-1155 Change input suggestion field for fields "From"/"To" in advance search Oct 30, 2023
@hieutbui hieutbui force-pushed the improvement/TF-1155-Change-weight-of-input-field-in-advance-search branch from a27d8fd to 8340323 Compare November 7, 2023 10:31
@hoangdat
Copy link
Member

hoangdat commented Nov 7, 2023 •
edited
Loading

@dab246 please take a look on it

Blocking

  • When open advance search 2nd time and click on 'From/To', UI not breaking but got error about _onFocusChange() function inside lib super_tag_editor.
  • When 'From' is on focus then press Tab => focus switch to 'To' and then disappear.
  • When 'To' is on focus then press Tab => focus disappear.
  • When focus is on 'From/To' then click on other fields, this 'From/To' will not collapse.

@dab246 dab246 changed the title [WIP] TF-1155 Change input suggestion field for fields "From"/"To" in advance search TF-1155 Change input suggestion field for fields "From"/"To" in advance search Nov 8, 2023
@dab246 dab246 self-assigned this Nov 8, 2023
dab246 added 8 commits November 8, 2023 11:26
@dab246
TF-1155 Allow click to select suggestion item
3a4408c 
Signed-off-by: dab246 <tdvu@linagora.com>
@dab246
TF-1155 Handle moving focus between fields using the tab key in advan…
3c6e5a3 
…ced search

Signed-off-by: dab246 <tdvu@linagora.com>
@dab246
TF-1155 Automatically collapsed and created tags when fields lose focus
99dc725 
Signed-off-by: dab246 <tdvu@linagora.com>
@dab246
TF-1155 Automatically clear value of From/To field when disable adv…
ab550d2 
…anced search

Signed-off-by: dab246 <tdvu@linagora.com>
@dab246
TF-1155 Update UI for input field
21f543c 
Signed-off-by: dab246 <tdvu@linagora.com>
@dab246
TF-1155 Remove class not used
ed100eb 
Signed-off-by: dab246 <tdvu@linagora.com>
@dab246
TF-1155 Update value From field when click quick search action
8effd41 
Signed-off-by: dab246 <tdvu@linagora.com>
@dab246
TF-1155 Call the search action when pressing enter on the keyboard
00f36cc 
Signed-off-by: dab246 <tdvu@linagora.com>
@dab246
Copy link
Member

dab246 commented Nov 8, 2023 •
edited
Loading

Resolved

Screen.Recording.2023-11-08.at.16.27.49.mov

Related

@hoangdat @hieutbui Please review it

@hieutbui
Copy link
Member Author

hieutbui commented Nov 8, 2023

I tested and it works as expected

dab246
dab246 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dab246 dab246 merged commit ef71d63 into master Nov 9, 2023
9 checks passed
@hoangdat hoangdat deleted the improvement/TF-1155-Change-weight-of-input-field-in-advance-search branch February 20, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqhhdev nqhhdev nqhhdev approved these changes

@dab246 dab246 dab246 approved these changes

@hoangdat hoangdat Awaiting requested review from hoangdat

Assignees

@dab246 dab246

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hieutbui @hoangdat @dab246 @nqhhdev