arm64: dt: OP-TEE for FVP Base RevC #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Jul 4, 2022
| @@ -28,7 +28,6 @@ | |||
|
|
|||
| aliases { | |||
| serial0 = &v2m_serial0; | |||
| serial1 = &v2m_serial1; | |||
There was a problem hiding this comment.
It was, but I'll restore that for now.
| compatible = "linaro,optee-tz"; | ||
| method = "smc"; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
How was the node added to the DT prior to this PR?
There was a problem hiding this comment.
It wasn't. We were only using the Foundation model, which needs a different DTB.
There was a problem hiding this comment.
OK, I thought we were using this file with our fvp.xml manifest.
There was a problem hiding this comment.
We are, if compiling with FVP_USE_BASE_PLAT=y. It was introduced with commit 1bf41f5d9b0d ("fvp: add Trusted Services support") in https://github.com/OP-TEE/build
Configures FVP Base RevC with OP-TEE.
With commit 1bf41f5d9b0d ("fvp: add Trusted Services support") in
https://github.com/OP-TEE/build there is support for building running
with the FVP Base RevC model. However, some updates to the DTB passed
to the kernel is missing for the OP-TEE driver to be probed. So fix that
by adding an OP-TEE node in the DTS.
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
|
Update |
|
Thanks for the details, all clear now. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures FVP Base RevC with OP-TEE.
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org