Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(addon/components/paper-card-actions): migrates to tagless native class. #25

Open
wants to merge 1 commit into
base: 10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_class
Choose a base branch
from
Open

feat(addon/components/paper-card-actions): migrates to tagless native class. #25

wants to merge 1 commit into from

Conversation

matthewhartstonge
Copy link
Member

@matthewhartstonge matthewhartstonge commented Oct 17, 2024 •
edited
Loading

  • removes lifecycle hooks by moving to a computed property (getter)
  • adds integration tests

This was referenced Oct 17, 2024
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
@matthewhartstonge Graphite App
Copy link
Member Author

matthewhartstonge commented Oct 17, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@matthewhartstonge matthewhartstonge mentioned this pull request Oct 17, 2024
Open
@matthewhartstonge matthewhartstonge marked this pull request as ready for review October 17, 2024 04:23
@matthewhartstonge matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_class branch from ae26cd5 to b7934b1 Compare October 17, 2024 04:24
@matthewhartstonge matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-actions_migrates_to_tagless_native_class branch from 3a6162d to 21de1c2 Compare October 17, 2024 04:24
@matthewhartstonge matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_class branch from b7934b1 to 5f42b93 Compare October 18, 2024 04:15
@matthewhartstonge matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-actions_migrates_to_tagless_native_class branch from 21de1c2 to 798d619 Compare October 18, 2024 04:15
@matthewhartstonge matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-image_migrates_to_tagless_native_class branch from 5f42b93 to 1dd71e0 Compare October 29, 2024 21:02
@matthewhartstonge matthewhartstonge force-pushed the 10-17-feat_addon_components_paper-card-actions_migrates_to_tagless_native_class branch from 798d619 to 3022ea9 Compare October 29, 2024 21:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Some tests with 'continue-on-error: true' have failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewhartstonge