-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrades to xlsx@0.20.3
via CDN
#46
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @matthewhartstonge and the rest of your teammates on Graphite |
@hero-david @pauln what are your thoughts on migrating to a git based dep...? 🤢 I'm not really a fan of pulling in a git repo, but it is pinned in the lock file to a specific commit hash. Sheetjs have yeeted themselves into their own world (gitea self hosted git) and removed themselves from pushing the dep up to npm :/ Refer: https://github.com/SheetJS/sheetjs/tree/github?tab=readme-ov-file#thank-you-clippy Tl;DR: Removes a couple of CVEs. |
The other options are:
They are supporting versions of node back to 0.8 and Angular v1.X clients, which is why they had to move away from npmjs. |
7b63ce7
to
10d6a92
Compare
xlsx@0.20.3
via CDN
10d6a92
to
5e843bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decision over chats was to move forward with using the CDN 👍
I didn't realise that git was an option 👀 Feels nicer than a tgz |
yarp - give 7b63ce7 a cheeky peep 👀 Can change back to git on a |
Fixes: