-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for signed commits through the Github API #492
base: master
Are you sure you want to change the base?
Conversation
Adding support to the GH API
Co-authored-by: Chris Statham <chris-statham@hotmail.com>
Co-authored-by: ChrisStatham <christopher.statham@thescore.com>
🙌 |
Hey @lindell I'm hoping to get a review on this code. Just wondering if you find it acceptable. I'm happy to add unit tests, if needed. |
I think adding API committing is reasonable.
I have not looked super close into all line of code, and do not want to do so at this point as things might still change. But something I found in at least two places where manual path handling through string manipulation. Please do use the Thanks for the contribution, looking forward to merging this 😄 |
+1 on this feature! |
What does this change
Give a summary of the change, and how it affects end-users. It's okay to copy/paste your commit messages.
This PR adds the ability to commit through the Github API, rather than through the git client. This creates a signed commit for both user accounts, and for Github Apps.
For example if it introduces a new flag or modifies a commands output, give an example of you running the command and showing real output here.
What issue does it fix
Closes #261
If there is not an existing issue, please make sure we have context on why this change is needed. .
Notes for the reviewer
Put any questions or notes for the reviewer here.
I'm checking to see if this PR is sane. I'm not sure if commit signing is available using a Github User, but Github Applications need to commit though the Github API in order to get signed commits. There is a fairly decent write up for this issue here
Committing through the API is guaranteed to create a signed commit, so it removes all ambiguity
Checklist