add scLUSD strategy #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fyang1024
approved these changes
May 23, 2023
coolhill
commented
May 23, 2023
fyang1024
reviewed
May 24, 2023
fyang1024
reviewed
May 24, 2023
brkomir
reviewed
May 25, 2023
| stabilityPool.provideToSP(depositAmount, address(0)); | ||
| } | ||
|
|
||
| function harvest(uint256 _lqtyAmount, bytes calldata _lqtySwapData, uint256 _ethAmount, bytes calldata _ethSwapData) |
There was a problem hiding this comment.
there is no slippage control for the two potential swaps this function performs, consider adding "_amountOutMin" parameter and revert execution if the amount received is below min
| // float is not allowed to be greater than 25% of the total | ||
| // invested since liquidation rewards can be dilluted by savy | ||
| // just-in-time depositors | ||
| uint256 float = asset.balanceOf(address(this)); |
There was a problem hiding this comment.
asset.balanceOf(address(this)) is repeated multiple times in the contract, consider refactoring this as an internal function
Comment on lines
+77
to
+81
| function depositIntoStrategy() external { | ||
| _depositIntoStrategy(); | ||
| } | ||
|
|
||
| function _depositIntoStrategy() internal { |
There was a problem hiding this comment.
having an external function to expose internal functionality without any added functionality seems unnecessary, consider changing the internal _depositIntoStrategy to public
Co-authored-by: Fei Yang <fyang1024@gmail.com> Co-authored-by: brkomir <91959886+brkomir@users.noreply.github.com>
coolhill
commented
May 25, 2023
Comment on lines
+84
to
+98
| function _depositIntoStrategy() internal { | ||
| uint256 float = asset.balanceOf(address(this)); | ||
| uint256 targetFloat = totalAssets().mulWadDown(floatPercentage); | ||
|
|
||
| if (float <= targetFloat) return; // nothing to invest | ||
|
|
||
| uint256 depositAmount = float - targetFloat; | ||
|
|
||
| // needed otherwise counted as profit during harvest | ||
| totalInvested += depositAmount; | ||
|
|
||
| stabilityPool.provideToSP(depositAmount, address(0)); | ||
|
|
||
| emit DepositedIntoStrategy(depositAmount); | ||
| } |
Check notice
Code scanning / Slither
Reentrancy vulnerabilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scLUSD: Deposit LUSD which will be deposited into the Liquity Stability Pool. Recieve scLUSD shares which appreciate over time and can be redeemed for LUSD. A keeper bot regularly reinvests profits which consists of discounted ETH on liquidations and Liquity community issuance ($LQTY). Strategy has exposure to Liquity, 0x exchange routing protocol and a combination oracle consiting of Chainlink ETH/USD and the Chainlink LUSD/USD price feeds.