deploy script for v2 vaults #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrin1
requested changes
Jun 14, 2023
Comment on lines
97
to
119
| function _deposit(sc4626 _vault, uint256 _amount) internal { | ||
| _vault.asset().approve(address(_vault), _amount); | ||
| _vault.deposit(_amount, deployerAddress); | ||
| } | ||
|
|
||
| function _swapWethForUsdc(uint256 _amount) internal { | ||
| weth.deposit{value: _amount}(); | ||
|
|
||
| weth.approve(C.UNISWAP_V3_SWAP_ROUTER, _amount); | ||
|
|
||
| ISwapRouter.ExactInputSingleParams memory params = ISwapRouter.ExactInputSingleParams({ | ||
| tokenIn: address(weth), | ||
| tokenOut: address(usdc), | ||
| fee: 500, // 0.05% | ||
| recipient: deployerAddress, | ||
| deadline: block.timestamp + 1000, | ||
| amountIn: _amount, | ||
| amountOutMinimum: 0, | ||
| sqrtPriceLimitX96: 0 | ||
| }); | ||
|
|
||
| ISwapRouter(C.UNISWAP_V3_SWAP_ROUTER).exactInputSingle(params); | ||
| } |
There was a problem hiding this comment.
we use these in v1 deployments too, we should abstract into a helper of some sort to reduce duplication
Comment on lines
22
to
28
| contract DeployScript is CREATE3Script { | ||
| uint256 deployerPrivateKey = uint256(vm.envBytes32("PRIVATE_KEY")); | ||
| address deployerAddress = vm.addr(deployerPrivateKey); | ||
| address keeper = vm.envAddress("KEEPER"); | ||
|
|
||
| WETH weth = WETH(payable(C.WETH)); | ||
| ERC20 usdc = ERC20(C.USDC); |
There was a problem hiding this comment.
ideally we make a base class that then the mainnet + testnet deployments can both use
difference in the mainnet & testnet deployments being then only what happens after the deployment
brkomir
requested review from
0xrin1 and
dxganta
and removed request for
coolhill
dxganta
approved these changes
Jun 19, 2023
dxganta
reviewed
Jun 19, 2023
|
|
||
| constructor() CREATE3Script(vm.envString("VERSION")) {} | ||
|
|
||
| contract DeployScript is MainnetDepolyBase { |
There was a problem hiding this comment.
spelling error => MainnetDepolyBase
0xrin1
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.