simplify reward and bonus calculations in sQuartz #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxganta
approved these changes
Jun 21, 2023
coolhill
pushed a commit
that referenced
this pull request
Jul 10, 2023
dxganta
added a commit
that referenced
this pull request
Jul 19, 2023
* staking contract "notifyRewardAmount" fix (#85) * staking contract "notifyRewardAmount" -> "startRewardsDistribution" refactor * remove unused error type * refactor to improve code quality of the scip staking contracts (#86) * staking contract "notifyRewardAmount" -> "startRewardsDistribution" refactor * refactor to improve code quality of the scip staking contracts * add fv report * rename * add visual assets * small edit * md doesnt render svg * fix path * fix size * size * text fixes * consistency * moving all constant values to Constants.sol and removing duplicates (#89) * renaming adapters to differentiate usage between scUSDCv2 & scWETHv2 (#91) * document the decision of not including LQTY into total assets (#94) * fix for the logic for maintaining the float balance on withdrawals (#92) * fixed the logic for maintaining float balance on withdrawals * fix min float test assertation * added script for scUSDCv2 rebalancing scenarios * update logs * compile issue fixed --------- Co-authored-by: 0xBRM <0xBRM@users.noreply.github.com> Co-authored-by: 0xBRM <9098352+0xBRM@users.noreply.github.com> Co-authored-by: 0xrin1 <0xrin1@protonmail.com> Co-authored-by: realdiganta <47485188+dxganta@users.noreply.github.com>
coolhill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.