rebase with upstream main #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pool name to extensions
Add CreateVToken event
Fix/inflation fee v3
Add support for pragma twaps
Update debt_caps to be pair specific
Skip pair collateralization check if max_ltv == 0
tserg
commented
Dec 20, 2024
Comment on lines
-148
to
+163
| vendor::erc20::{IERC20MetadataDispatcher, IERC20MetadataDispatcherTrait}, | ||
| vendor::erc20::{ERC20ABIDispatcher as IERC20Dispatcher, ERC20ABIDispatcherTrait}, units::INFLATION_FEE, |
There was a problem hiding this comment.
I reverted back to ERC20ABIDispatcher because that is already now used for token approvals.
milancermak
approved these changes
Dec 20, 2024
Yes! I will open a PR against the main repo to check the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ekubo tests are passing locally. There is just one thing to highlight in the comment below. We can open the PR against the upstream once this is merged.
In the earlier PR, I suggested:
Thinking about this again today, I think it might not be an issue. Let's say the quote asset is USDC, collateral asset is USDC, and borrow asset is STRK. Assuming the threshold for STRK is 80%, then even though the price of 1 USDC is always 1 USDC, but we can still liquidate this position if STRK's price > 0.8 USDC. Maybe we can do away with this requirement first, and raise it in the upstream PR?