minor fixes

line · Jun 28, 2023 · 147d374 · 147d374
1 parent e930da9
commit 147d374
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 38 deletions.
diff --git a/observation/src/main/java/com/linecorp/armeria/client/observation/HttpClientContext.java b/observation/src/main/java/com/linecorp/armeria/client/observation/HttpClientContext.java
@@ -32,7 +32,7 @@ final class HttpClientContext extends RequestReplySenderContext<RequestHeadersBu
  private final HttpRequest httpRequest;
 
  HttpClientContext(ClientRequestContext clientRequestContext, RequestHeadersBuilder carrier,
-  HttpRequest httpRequest) {
+ HttpRequest httpRequest) {
  super(RequestHeadersBuilder::add);
  this.clientRequestContext = clientRequestContext;
  this.httpRequest = httpRequest;

diff --git a/...on/src/main/java/com/linecorp/armeria/client/observation/MicrometerObservationClient.java b/...on/src/main/java/com/linecorp/armeria/client/observation/MicrometerObservationClient.java
@@ -74,10 +74,9 @@ private MicrometerObservationClient(HttpClient delegate, ObservationRegistry obs
  /**
  * Creates a new instance.
  */
- private MicrometerObservationClient(HttpClient delegate,
- ObservationRegistry observationRegistry,
- @Nullable HttpClientObservationConvention
- httpClientObservationConvention) {
+ private MicrometerObservationClient(
+ HttpClient delegate, ObservationRegistry observationRegistry,
+ @Nullable HttpClientObservationConvention httpClientObservationConvention) {
  super(delegate);
  this.observationRegistry = observationRegistry;
  this.httpClientObservationConvention = httpClientObservationConvention;

diff --git a/observation/src/main/java/com/linecorp/armeria/server/observation/HttpServerContext.java b/observation/src/main/java/com/linecorp/armeria/server/observation/HttpServerContext.java
@@ -22,9 +22,6 @@
 
 import io.micrometer.observation.transport.RequestReplyReceiverContext;
 
-/**
- * TODO: Add me.
- */
 final class HttpServerContext extends RequestReplyReceiverContext<HttpRequest, RequestLog> {
 
  private final ServiceRequestContext serviceRequestContext;

diff --git a/...rc/main/java/com/linecorp/armeria/server/observation/ServiceObservationDocumentation.java b/...rc/main/java/com/linecorp/armeria/server/observation/ServiceObservationDocumentation.java
@@ -45,99 +45,69 @@ public Event[] getEvents() {
 
  enum HighCardinalityKeys implements KeyName {
 
- /**
- * TODO: Add me.
- */
  HTTP_PATH {
  @Override
  public String asString() {
  return "http.path";
  }
  },
 
- /**
- * TODO: Add me.
- */
  HTTP_METHOD {
  @Override
  public String asString() {
  return "http.method";
  }
  },
 
- /**
- * TODO: Add me.
- */
  HTTP_HOST {
  @Override
  public String asString() {
  return "http.host";
  }
  },
 
- /**
- * TODO: Add me.
- */
  HTTP_URL {
  @Override
  public String asString() {
  return "http.url";
  }
  },
 
- /**
- * TODO: Add me.
- */
  HTTP_PROTOCOL {
  @Override
  public String asString() {
  return "http.protocol";
  }
  },
 
- /**
- * TODO: Add me.
- */
  HTTP_SERIALIZATION_FORMAT {
  @Override
  public String asString() {
  return "http.serfmt";
  }
  },
 
- /**
- * TODO: Add me.
- */
  ADDRESS_REMOTE {
  @Override
  public String asString() {
  return "address.remote";
  }
  },
 
- /**
- * TODO: Add me.
- */
  ADDRESS_LOCAL {
  @Override
  public String asString() {
  return "address.local";
  }
  },
 
- /**
- * TODO: Add me.
- */
  STATUS_CODE {
  @Override
  public String asString() {
  return "http.status_code";
  }
  },
 
- /**
- * TODO: Add me.
- */
  ERROR {
  @Override
  public String asString() {