fix: logger.warn instead of ISE on transcoding options for non-unary …

…gRPC
line · Jul 25, 2024 · b6f276f · b6f276f
1 parent 104855a
commit b6f276f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/grpc/src/main/java/com/linecorp/armeria/server/grpc/HttpJsonTranscodingService.java b/grpc/src/main/java/com/linecorp/armeria/server/grpc/HttpJsonTranscodingService.java
@@ -159,10 +159,12 @@ static GrpcService of(GrpcService delegate, HttpJsonTranscodingOptions httpJsonT
 
  final HttpRule httpRule = methodOptions.getExtension(AnnotationsProto.http);
 
- checkArgument(methodDefinition.getMethodDescriptor().getType() == MethodType.UNARY,
- "Only unary methods can be configured with an HTTP/JSON endpoint: " +
- "method=%s, httpRule=%s",
- methodDefinition.getMethodDescriptor().getFullMethodName(), httpRule);
+ if (methodDefinition.getMethodDescriptor().getType() != MethodType.UNARY) {
+ logger.warn("Only unary methods can be configured with an HTTP/JSON endpoint: " +
+ "method={}, httpRule={}",
+ methodDefinition.getMethodDescriptor().getFullMethodName(), httpRule);
+ continue;
+ }
 
  @Nullable
  final Entry<Route, List<PathVariable>> routeAndVariables = toRouteAndPathVariables(httpRule);

diff --git a/grpc/src/test/proto/testing/grpc/transcoding.proto b/grpc/src/test/proto/testing/grpc/transcoding.proto
@@ -237,6 +237,12 @@ service HttpJsonTranscodingTestService {
  post: "/v1/arbitrary_wrapped"
  };
  }
+
+ rpc EchoBidirectionalStream(stream Message) returns (stream Message) {
+ option (google.api.http) = {
+ post: "/v1/echo/bidirectional_stream"
+ };
+ }
 }
 
 message GetMessageRequestV1 {