Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocService - Struct field docstrings are not reliably included #186

Closed
anuraaga opened this issue Jun 6, 2016 · 0 comments
Closed

DocService - Struct field docstrings are not reliably included #186

anuraaga opened this issue Jun 6, 2016 · 0 comments
Assignees
@jongyeol
Labels
defect
Milestone
0.20.1.Final

Comments

@anuraaga
Copy link
Collaborator

anuraaga commented Jun 6, 2016

When applying the docstring changes to an actual service, I found that field comments don't always show up, even though they are included in the JSON. I suspect something to do with the "field key" computation.
jongyeol added a commit to jongyeol/armeria that referenced this issue Jun 16, 2016
@jongyeol
Fix line#186 DocService Struct field docstrings are not reliably incl…
7ea8bb2 
…uded
@jongyeol jongyeol mentioned this issue Jun 16, 2016
Merged
trustin added a commit that referenced this issue Jun 17, 2016
@trustin
Merge pull request #190 from jongyeol/feature/fix-doc-service-struct-…
4df7b24 
…param

Fix #186 DocService Struct field docstrings are not reliably included
@trustin trustin added this to the 0.20.1.Final milestone Dec 28, 2016
@trustin trustin added the defect label Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongyeol jongyeol

Labels
defect
Projects
None yet
Milestone
0.20.1.Final
Development

No branches or pull requests
3 participants
@jongyeol @trustin @anuraaga