-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More efficient and correct H1C-to-H2C upgrade #107
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
src/main/java/com/linecorp/armeria/client/DefaultHostsFileEntriesResolver.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Copyright 2015 The Netty Project | ||
* | ||
* The Netty Project licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package com.linecorp.armeria.client; | ||
|
||
import java.net.InetAddress; | ||
import java.util.Map; | ||
|
||
import io.netty.resolver.HostsFileEntriesResolver; | ||
|
||
/** | ||
* Default {@link HostsFileEntriesResolver} that resolves hosts file entries only once. | ||
*/ | ||
final class DefaultHostsFileEntriesResolver implements HostsFileEntriesResolver { | ||
// TODO(trustin): Remove this fork once Netty 4.1.0.CR2 is out. | ||
private final Map<String, InetAddress> entries = HostsFileParser.parseSilently(); | ||
|
||
@Override | ||
public InetAddress address(String inetHost) { | ||
return entries.get(inetHost); | ||
} | ||
} |
175 changes: 175 additions & 0 deletions
175
src/main/java/com/linecorp/armeria/client/HostsFileParser.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,175 @@ | ||
/* | ||
* Copyright 2015 The Netty Project | ||
* | ||
* The Netty Project licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package com.linecorp.armeria.client; | ||
|
||
import static io.netty.util.internal.ObjectUtil.checkNotNull; | ||
|
||
import java.io.BufferedReader; | ||
import java.io.File; | ||
import java.io.FileReader; | ||
import java.io.IOException; | ||
import java.io.Reader; | ||
import java.net.InetAddress; | ||
import java.util.ArrayList; | ||
import java.util.Collections; | ||
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.regex.Pattern; | ||
|
||
import io.netty.util.NetUtil; | ||
import io.netty.util.internal.PlatformDependent; | ||
import io.netty.util.internal.logging.InternalLogger; | ||
import io.netty.util.internal.logging.InternalLoggerFactory; | ||
|
||
/** | ||
* A parser for hosts files. | ||
*/ | ||
final class HostsFileParser { | ||
// TODO(trustin): Remove this fork once Netty 4.1.0.CR2 is out. | ||
private static final String WINDOWS_DEFAULT_SYSTEM_ROOT = "C:\\Windows"; | ||
private static final String WINDOWS_HOSTS_FILE_RELATIVE_PATH = "\\system32\\drivers\\etc\\hosts"; | ||
private static final String X_PLATFORMS_HOSTS_FILE_PATH = "/etc/hosts"; | ||
|
||
private static final Pattern WHITESPACES = Pattern.compile("[ \t]+"); | ||
|
||
private static final InternalLogger logger = InternalLoggerFactory.getInstance(HostsFileParser.class); | ||
|
||
private static File locateHostsFile() { | ||
File hostsFile; | ||
if (PlatformDependent.isWindows()) { | ||
hostsFile = new File(System.getenv("SystemRoot") + WINDOWS_HOSTS_FILE_RELATIVE_PATH); | ||
if (!hostsFile.exists()) { | ||
hostsFile = new File(WINDOWS_DEFAULT_SYSTEM_ROOT + WINDOWS_HOSTS_FILE_RELATIVE_PATH); | ||
} | ||
} else { | ||
hostsFile = new File(X_PLATFORMS_HOSTS_FILE_PATH); | ||
} | ||
return hostsFile; | ||
} | ||
|
||
/** | ||
* Parse hosts file at standard OS location. | ||
* | ||
* @return a map of hostname or alias to {@link InetAddress} | ||
*/ | ||
static Map<String, InetAddress> parseSilently() { | ||
File hostsFile = locateHostsFile(); | ||
try { | ||
return parse(hostsFile); | ||
} catch (IOException e) { | ||
logger.warn("Failed to load and parse hosts file at " + hostsFile.getPath(), e); | ||
return Collections.emptyMap(); | ||
} | ||
} | ||
|
||
/** | ||
* Parse hosts file at standard OS location. | ||
* | ||
* @return a map of hostname or alias to {@link InetAddress} | ||
* @throws IOException file could not be read | ||
*/ | ||
static Map<String, InetAddress> parse() throws IOException { | ||
return parse(locateHostsFile()); | ||
} | ||
|
||
/** | ||
* Parse a hosts file. | ||
* | ||
* @param file the file to be parsed | ||
* @return a map of hostname or alias to {@link InetAddress} | ||
* @throws IOException file could not be read | ||
*/ | ||
static Map<String, InetAddress> parse(File file) throws IOException { | ||
checkNotNull(file, "file"); | ||
if (file.exists() && file.isFile()) { | ||
return parse(new BufferedReader(new FileReader(file))); | ||
} else { | ||
return Collections.emptyMap(); | ||
} | ||
} | ||
|
||
/** | ||
* Parse a reader of hosts file format. | ||
* | ||
* @param reader the file to be parsed | ||
* @return a map of hostname or alias to {@link InetAddress} | ||
* @throws IOException file could not be read | ||
*/ | ||
static Map<String, InetAddress> parse(Reader reader) throws IOException { | ||
checkNotNull(reader, "reader"); | ||
BufferedReader buff = new BufferedReader(reader); | ||
try { | ||
Map<String, InetAddress> entries = new HashMap<>(); | ||
String line; | ||
while ((line = buff.readLine()) != null) { | ||
// remove comment | ||
int commentPosition = line.indexOf('#'); | ||
if (commentPosition != -1) { | ||
line = line.substring(0, commentPosition); | ||
} | ||
// skip empty lines | ||
line = line.trim(); | ||
if (line.isEmpty()) { | ||
continue; | ||
} | ||
|
||
// split | ||
List<String> lineParts = new ArrayList<>(); | ||
for (String s: WHITESPACES.split(line)) { | ||
if (!s.isEmpty()) { | ||
lineParts.add(s); | ||
} | ||
} | ||
|
||
// a valid line should be [IP, hostname, alias*] | ||
if (lineParts.size() < 2) { | ||
// skip invalid line | ||
continue; | ||
} | ||
|
||
byte[] ipBytes = NetUtil.createByteArrayFromIpAddressString(lineParts.get(0)); | ||
|
||
if (ipBytes == null) { | ||
// skip invalid IP | ||
continue; | ||
} | ||
|
||
// loop over hostname and aliases | ||
for (int i = 1; i < lineParts.size(); i ++) { | ||
String hostname = lineParts.get(i); | ||
if (!entries.containsKey(hostname)) { | ||
// trying to map a host to multiple IPs is wrong | ||
// only the first entry is honored | ||
entries.put(hostname, InetAddress.getByAddress(hostname, ipBytes)); | ||
} | ||
} | ||
} | ||
return entries; | ||
} finally { | ||
try { | ||
buff.close(); | ||
} catch (IOException e) { | ||
logger.warn("Failed to close a reader", e); | ||
} | ||
} | ||
} | ||
|
||
/** | ||
* Can't be instantiated. | ||
*/ | ||
private HostsFileParser() {} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this high priority enough to fork for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Good news is Netty 4.1.0.CR2 is out already. Will update this PR when I'm back from holiday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually 4.1.0.CR2 has an another regression in HTTP/2 implementation, so we'll have to wait for CR3. The maintenance cost is low and I'd like to keep it for now.