Use RpcRequest.method() as Zipkin span name #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Pre-0.21 used a Thrift method name as Zipkin span name, but 0.21 always uses HTTP method name. Modifications: - Use RpcRequest.method() as Zipkin span name if available via RequestLog Result: More conprehensive and Backward-compatible behavior
Current coverage is 64.02% (diff: 100%)@@ master #221 diff @@
==========================================
Files 277 277
Lines 10588 10596 +8
Methods 0 0
Messages 0 0
Branches 1531 1533 +2
==========================================
- Hits 6792 6784 -8
- Misses 3057 3073 +16
Partials 739 739
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Pre-0.21 used a Thrift method name as Zipkin span name, but 0.21 always
uses HTTP method name.
Modifications:
RequestLog
Result:
More conprehensive and Backward-compatible behavior