Fix query and fragment removed from request #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: DefaultSimpleHttpClient did not used query and fragment from original URI from request. Modifications: - Build string from path, query and fragment in original URI so query and fragment are not removed. Result: Proper request while using `SimpleHttpClient`
Current coverage is 64.06% (diff: 33.33%)@@ master #224 diff @@
==========================================
Files 277 277
Lines 10603 10611 +8
Methods 0 0
Messages 0 0
Branches 1534 1536 +2
==========================================
- Hits 6806 6798 -8
- Misses 3059 3071 +12
- Partials 738 742 +4
|
|
Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
DefaultSimpleHttpClient did not used query and fragment from original
URI from request.
Modifications:
and fragment are not removed.
Result:
Proper request while using
SimpleHttpClient