Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct FindBugs-JSR305 license #3290

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Correct FindBugs-JSR305 license #3290

merged 2 commits into from
Jan 20, 2021

Conversation

syleeeee
Copy link
Member

I found JSR305 is actually BSD-licensed, not Apache 2.0.
Somehow there's wrong information at maven.

You can see the discussion regarding the JSR305 license here.

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #3290 (e4bbb93) into master (1294521) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3290      +/-   ##
============================================
- Coverage     74.08%   74.07%   -0.01%     
+ Complexity    13010    13007       -3     
============================================
  Files          1136     1136              
  Lines         49276    49276              
  Branches       6256     6256              
============================================
- Hits          36505    36503       -2     
- Misses         9556     9557       +1     
- Partials       3215     3216       +1     
Impacted Files Coverage Δ Complexity Δ
...ia/internal/common/stream/ByteBufDecoderInput.java 86.45% <0.00%> (-3.13%) 29.00% <0.00%> (-2.00%)
.../linecorp/armeria/client/Http2ResponseDecoder.java 70.76% <0.00%> (-2.31%) 40.00% <0.00%> (ø%)
.../linecorp/armeria/client/DefaultClientFactory.java 69.89% <0.00%> (-2.16%) 29.00% <0.00%> (-1.00%)
...m/linecorp/armeria/server/thrift/THttpService.java 73.81% <0.00%> (-2.15%) 52.00% <0.00%> (-1.00%)
.../com/linecorp/armeria/server/RoutingPredicate.java 70.96% <0.00%> (-1.62%) 21.00% <0.00%> (-1.00%)
...inecorp/armeria/server/grpc/ArmeriaServerCall.java 85.07% <0.00%> (-1.12%) 89.00% <0.00%> (ø%)
...p/armeria/internal/common/eureka/InstanceInfo.java 51.75% <0.00%> (-0.88%) 23.00% <0.00%> (-1.00%)
...corp/armeria/client/RefreshingAddressResolver.java 76.42% <0.00%> (-0.72%) 19.00% <0.00%> (-1.00%)
...inecorp/armeria/server/HttpResponseSubscriber.java 79.21% <0.00%> (-0.40%) 58.00% <0.00%> (ø%)
...corp/armeria/common/logging/DefaultRequestLog.java 76.32% <0.00%> (-0.26%) 223.00% <0.00%> (-1.00%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1294521...1ea1572. Read the comment docs.

@ikhoon ikhoon added this to the 1.4.0 milestone Jan 19, 2021
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @syleeeee
I didn't know that the jar deployed to Maven Central has wrong information.

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

NOTICE.txt Outdated Show resolved Hide resolved
@trustin trustin changed the title Correct FingBugs-JSR305 license Correct FindBugs-JSR305 license Jan 20, 2021
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Copy link
Member

@trustin trustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @syleeeee and @anuraaga !

@trustin trustin merged commit 077f547 into line:master Jan 20, 2021
@syleeeee syleeeee deleted the jsr305-license branch January 20, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants