Provide RequestHeaders to ServerErrorHandler
#4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikhoon
approved these changes
Jan 21, 2022
core/src/main/java/com/linecorp/armeria/server/DefaultServerErrorHandler.java
Outdated
Show resolved
Hide resolved
trustin
force-pushed
the
expose_headers_in_error_handler
branch
from
6c2c7c4
to
12626aa
Compare
Motivation:
A user sometimes wants to generate an error response differently
depending on a certain request header value. For example:
- Include a certain request header value in an error response for easier
troubleshooting; or
- Provide a different level of detail for the requests that contain
a certain header.
Modifications:
- Added an optional `RequestHeaders` parameter to `ServerErrorHandler`
methods.
- Modified `Http{1,2}RequestDecoder` so it constructs a `RequestHeaders`
as early as possible, so that `ServerErrorHandler` is given with a
non-null `RequestHeaders` in most cases.
- Updated `CustomServerErrorHandlerTest` to demonstrate this feature.
Result:
- (new feature) A user can generate an error response differently
depending on the request headers.
- (breaking changes) The method signatures of `ServerErrorHandler` has
been changed.
minwoox
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A user sometimes wants to generate an error response differently
depending on a certain request header value. For example:
troubleshooting; or
a certain header.
Modifications:
RequestHeadersparameter toServerErrorHandlermethods.
Http{1,2}RequestDecoderso it constructs aRequestHeadersas early as possible, so that
ServerErrorHandleris given with anon-null
RequestHeadersin most cases.CustomServerErrorHandlerTestto demonstrate this feature.Result:
depending on the request headers.
ServerErrorHandlerhasbeen changed.