Ensure the post-process of a response is executed without a local request context #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uest context Motivation: A listener of a `ChannelFuture` can have a different request context in the thread local because Netty may handle some pending requests in a batch task which can may be triggered by a event loop having the different request context. Modifications: - Remove a request context from thread local before invoking `tryComplete()` Result: Fixed a potential context leak when an incomplete `HttpResponse` is returned.
jrhee17
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A listener of a
ChannelFuturecan have a different request context in the thread local. Because Netty handles some pending requests in a batch task with an event loop having the different request context.Modifications:
tryComplete()Result:
Fixed a potential
RequestContextleak when an incompleteHttpResponseis returned.