Add release notes for 1.25.0 #5114

jrhee17 · 2023-08-15T09:45:12Z

codecov · 2023-08-15T10:19:03Z

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (1ce4c69) 74.30% compared to head (2090811) 74.29%.
Report is 8 commits behind head on main.

❗ Current head 2090811 differs from pull request most recent head 1f6d69b. Consider uploading reports for the commit 1f6d69b to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5114      +/-   ##
============================================
- Coverage     74.30%   74.29%   -0.02%     
- Complexity    19600    19619      +19     
============================================
  Files          1682     1683       +1     
  Lines         72260    72585     +325     
  Branches       9242     9304      +62     
============================================
+ Hits          53695    53927     +232     
- Misses        14222    14285      +63     
- Partials       4343     4373      +30

see 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

site/src/pages/release-notes/1.25.0.mdx

github-actions · 2023-08-21T02:45:22Z

🔍 Build Scan® (commit: `1f6d69b`)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	✅	https://ge.armeria.dev/s/r4hadm742wfg6
build-self-hosted-jdk-8	✅	https://ge.armeria.dev/s/2astuwjphukag
build-self-hosted-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/lty66g62bkqwe
build-self-hosted-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/xsnid4g76wey4
build-self-hosted-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/npu4rv5smh36m
build-self-hosted-jdk-17-leak	✅	https://ge.armeria.dev/s/wmy3xwcqnx7qw
build-self-hosted-jdk-11	✅	https://ge.armeria.dev/s/qacm2frbzvmgo
build-macos-12-jdk-19	❌ (failure)	https://ge.armeria.dev/s/cz4kwyx2fha36

minwoox

Left minor suggestions. Thanks! 👍

site/src/pages/release-notes/1.25.0.mdx

minwoox · 2023-08-22T01:27:56Z

site/src/pages/release-notes/1.25.0.mdx

+    .decorator(ObservationService.newDecorator(observationRegistry))
+  ...
+  ```
+- You may now use <type://WebSocketClient> to call websocket services. #4972


- **WebSocket Support**: You can now send and receive data over [WebSocket](https://en.wikipedia.org/wiki/WebSocket) using <type://WebSocketClient>.

minwoox · 2023-08-22T01:30:05Z

site/src/pages/release-notes/1.25.0.mdx

+    webSocketSessions.inbound().subscribe(subscriber);
+  });
+  ```
+- <type://GoogleGrpcStatusFunction> is introduced so that users can more easily implement


How about:

You can now easily use gRPC [Richer Error Model](https://grpc.io/docs/guides/error/#richer-error-model) via <type://GoogleGrpcStatusFunction>.

minwoox · 2023-08-22T01:30:23Z

site/src/pages/release-notes/1.25.0.mdx

+  if (throwable instanceof MyException) {
+        return ...;


Suggested change

if (throwable instanceof MyException) {

return ...;

if (throwable instanceof MyException) {

return ...;

How about also returning the Status so that users notice what the return type is?

if (throwable instanceof MyAuthenticationException) { return com.google.rpc.Status.newBuilder() .setCode(Code.UNAUTHENTICATED.getNumber()) .addDetails(detail(throwable)) .build(); } ...

minwoox · 2023-08-22T01:52:43Z

site/src/pages/release-notes/1.25.0.mdx

+    GrpcService.builder()
+      .exceptionMapping(statusFunction)
+  ```
+- Users can now retrieve headers from a multipart request in an annotated service


I believe that we are writing release notes with a more user-focused style. 😉
https://www.knowledgeowl.com/blog/posts/release-notes-anne-edwards/

Suggested change

- Users can now retrieve headers from a multipart request in an annotated service

- You can now retrieve headers from a multipart request in an annotated service

minwoox · 2023-08-22T01:54:09Z

site/src/pages/release-notes/1.25.0.mdx

+  alive when a HTTP/2 PING frame or `OPTIONS * HTTP/1.1` is received. The option can be configured
+  by <type://ServerBuilder#idleTimeout(Duration,boolean)> or
+  <type://ClientFactoryBuilder#idleTimeout(Duration,boolean)>. #4794 #4806
+- You can now easily create a <type://StreamMessage> from a future using <type://StreamMessage#of(CompletionStage<?>)>. #4995


future -> CompletableFuture

minwoox · 2023-08-22T01:57:24Z

site/src/pages/release-notes/1.25.0.mdx

+## 📈 Improvements
+
+- The number of event loops is equal to the number of cores by default when `io_uring` is used as the transport type. #5089
+- Users may now customize error responses when a service for a request is not found


Suggested change

- Users may now customize error responses when a service for a request is not found

- You can now customize error responses when a service for a request is not found

minwoox · 2023-08-22T02:01:51Z

site/src/pages/release-notes/1.25.0.mdx

+
+- <type://GrpcService> now returns an `INTERNAL` error code if an error occurs while serializing gRPC metadata. #4625 #4686
+- <type://DnsCache> now allows zero TTL for resolved DNS records. #5119
+- Armeria's DNS resolver doesn't cache a DNS query timeout. #5117


Suggested change

- Armeria's DNS resolver doesn't cache a DNS query timeout. #5117

- Armeria's DNS resolver doesn't cache a DNS whose query was timed out. #5117

minwoox · 2023-08-22T02:05:44Z

site/src/pages/release-notes/1.25.0.mdx

+- Fixed a bug where headers could be written twice if `Content-Length` was exceeded during HTTP/2 cleartext upgrade. #5113
+- <type://ServiceRequestContext#localAddress()> and <type://ServiceRequestContext#remoteAddress()> now return
+  correct values when using domain sockets in abstract namespace. #5096
+- `armeria-logback12`, `armeria-logback13`, `armeria-logback14` have been introduced for better


Suggested change

- `armeria-logback12`, `armeria-logback13`, `armeria-logback14` have been introduced for better

- `armeria-logback12`, `armeria-logback13`, and `armeria-logback14` have been introduced for better

minwoox · 2023-08-22T02:07:01Z

site/src/pages/release-notes/1.25.0.mdx

+- <type://HttpResponse#from(CompletionStage)> and its variants methods are deprecated.
+  - Use <type://HttpResponse#of(CompletionStage)> and its variants instead. #5075


Suggested change

- <type://HttpResponse#from(CompletionStage)> and its variants methods are deprecated.

- Use <type://HttpResponse#of(CompletionStage)> and its variants instead. #5075

- <type://HttpResponse#from(CompletionStage)> and its variants methods are deprecated. #5075

- Use <type://HttpResponse#of(CompletionStage)> and its variants instead.

minwoox

Thanks! 👍 👍 👍

site/src/pages/release-notes/1.25.0.mdx

minwoox · 2023-08-22T02:22:13Z

site/src/pages/release-notes/1.25.0.mdx

+- **Keep an Idle Connection Alive on PING**: The `keepAliveOnPing` option has been introduced. Enabling this option will keep
+  an idle connection alive when a HTTP/2 PING frame or `OPTIONS * HTTP/1.1` is received. The option can be configured
+  by <type://ServerBuilder#idleTimeout(Duration,boolean)> or <type://ClientFactoryBuilder#idleTimeout(Duration,boolean)>. #4794 #4806
+- **Create a StreamMessage from Future**: You can now easily create a <type://StreamMessage> from a <type://CompletionStage>


Suggested change

- **Create a StreamMessage from Future**: You can now easily create a <type://StreamMessage> from a <type://CompletionStage>

- **Create a StreamMessage from Future**: You can now easily create a <type://StreamMessage> from a `CompletionStage`

Because CompletionStage is not an API from Armeria, it's not rendered via type.

Co-authored-by: minux <songmw725@gmail.com>

ikhoon · 2023-08-22T02:15:53Z

site/src/pages/release-notes/1.25.0.mdx

+date: 2023-08-22
+---
+
+## 🌟 New features


Notes for the newly added commits:

- You can now easily set trailers to be sent after the data stream using <type://HttpResponse#of(RequestHeaders,Publisher,HttpHeaders)>. #3959 #4727

ikhoon · 2023-08-22T02:35:37Z

site/src/pages/release-notes/1.25.0.mdx

+- Kafka client 3.4.0 → 3.4.1
+- Kotlin 1.8.22 → 1.9.0
+- Kotlin Coroutine 1.7.1 → 1.7.3
+- Logback 1.4.8 → 1.4.11


https://github.com/line/armeria/blob/armeria-1.24.3/dependencies.toml#L81

Suggested change

- Logback 1.4.8 → 1.4.11

- Logback 1.4.7 → 1.4.11

ikhoon · 2023-08-22T02:36:28Z

site/src/pages/release-notes/1.25.0.mdx

+- Kotlin Coroutine 1.7.1 → 1.7.3
+- Logback 1.4.8 → 1.4.11
+- Micrometer 1.11.1 → 1.11.3
+- Netty 4.1.95.Final → 4.1.96.Final


https://github.com/line/armeria/blob/armeria-1.24.3/dependencies.toml#L87

Suggested change

- Netty 4.1.95.Final → 4.1.96.Final

- Netty 4.1.94.Final → 4.1.96.Final

ikhoon · 2023-08-22T02:37:54Z

site/src/pages/release-notes/1.25.0.mdx

+
+## ⛓ Dependencies
+
+- gRPC-Java 1.56.1 → 1.57.2


https://github.com/line/armeria/blob/armeria-1.24.3/dependencies.toml#L38

Suggested change

- gRPC-Java 1.56.1 → 1.57.2

- gRPC-Java 1.56.0 → 1.57.2

ikhoon · 2023-08-22T02:43:31Z

site/src/pages/release-notes/1.25.0.mdx

+
+## 🌟 New features
+
+- **GraalVM Support**: You can now easily build [GraalVM](https://www.graalvm.org/) native images for Armeria applications. #5005


How about?

Suggested change

- **GraalVM Support**: You can now easily build [GraalVM](https://www.graalvm.org/) native images for Armeria applications. #5005

- **GraalVM Support**: Armeria now provides [GraalVM](https://www.graalvm.org/) [reachability metadata](https://www.graalvm.org/latest/reference-manual/native-image/metadata/) to easily build [GraalVM](https://www.graalvm.org/) native images. #5005

trustin

Capitalization consistency + two new changes 🙇

site/src/pages/release-notes/1.25.0.mdx

Co-authored-by: Trustin Lee <t@motd.kr>

ikhoon

Thanks, @jrhee17! 🙇‍♂️🚀

trustin

Niiiice! 🙇

jrhee17 added the documentation label Aug 15, 2023

jrhee17 added this to the 1.25.0 milestone Aug 15, 2023

trustin reviewed Aug 18, 2023

View reviewed changes

site/src/pages/release-notes/1.25.0.mdx Outdated Show resolved Hide resolved

site/src/pages/release-notes/1.25.0.mdx Outdated Show resolved Hide resolved

jrhee17 and others added 2 commits August 21, 2023 15:25

init

ab4bd9f

rerun release-note

b2e6152

jrhee17 force-pushed the release/1.25.0 branch from b8f04af to b2e6152 Compare August 21, 2023 08:14

fix rendering

493f4c4

jrhee17 force-pushed the release/1.25.0 branch from d1e7310 to 493f4c4 Compare August 21, 2023 08:21

jrhee17 marked this pull request as ready for review August 21, 2023 08:23

jrhee17 requested review from ikhoon and minwoox as code owners August 21, 2023 08:23

add headers for new features

153d7cf

minwoox reviewed Aug 22, 2023

View reviewed changes

address comments by @minwoox

2ef2a9c

minwoox approved these changes Aug 22, 2023

View reviewed changes

jrhee17 and others added 6 commits August 22, 2023 11:28

Update site/src/pages/release-notes/1.25.0.mdx

5866b64

Co-authored-by: minux <songmw725@gmail.com>

Update site/src/pages/release-notes/1.25.0.mdx

d14a479

Co-authored-by: minux <songmw725@gmail.com>

Update site/src/pages/release-notes/1.25.0.mdx

a0a187f

Co-authored-by: minux <songmw725@gmail.com>

Update site/src/pages/release-notes/1.25.0.mdx

13222f2

Co-authored-by: minux <songmw725@gmail.com>

Update site/src/pages/release-notes/1.25.0.mdx

4488654

Co-authored-by: minux <songmw725@gmail.com>

address comment by @minwoox

0cef34e

ikhoon reviewed Aug 22, 2023

View reviewed changes

address comments by @ikhoon

2090811

trustin reviewed Aug 22, 2023

View reviewed changes

jrhee17 and others added 3 commits August 22, 2023 13:14

Update site/src/pages/release-notes/1.25.0.mdx

83c68d8

Co-authored-by: Trustin Lee <t@motd.kr>

Update site/src/pages/release-notes/1.25.0.mdx

c369f7e

Co-authored-by: Trustin Lee <t@motd.kr>

use chicago style titles

914d703

ikhoon approved these changes Aug 22, 2023

View reviewed changes

Add an item for PrometheusExpositionService changes

1f6d69b

trustin approved these changes Aug 22, 2023

View reviewed changes

jrhee17 merged commit cdcb18e into line:main Aug 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add release notes for 1.25.0 #5114

Add release notes for 1.25.0 #5114

jrhee17 commented Aug 15, 2023 •

edited

Loading

codecov bot commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 21, 2023 •

edited

Loading

minwoox left a comment

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox Aug 22, 2023

minwoox left a comment

minwoox Aug 22, 2023

ikhoon Aug 22, 2023 •

edited

Loading

ikhoon Aug 22, 2023

ikhoon Aug 22, 2023

ikhoon Aug 22, 2023

ikhoon Aug 22, 2023

trustin left a comment

ikhoon left a comment

trustin left a comment

	- Users can now retrieve headers from a multipart request in an annotated service
	- You can now retrieve headers from a multipart request in an annotated service

	- Users may now customize error responses when a service for a request is not found
	- You can now customize error responses when a service for a request is not found

	- Armeria's DNS resolver doesn't cache a DNS query timeout. #5117
	- Armeria's DNS resolver doesn't cache a DNS whose query was timed out. #5117

	- `armeria-logback12`, `armeria-logback13`, `armeria-logback14` have been introduced for better
	- `armeria-logback12`, `armeria-logback13`, and `armeria-logback14` have been introduced for better

		- <type://HttpResponse#from(CompletionStage)> and its variants methods are deprecated.
		- Use <type://HttpResponse#of(CompletionStage)> and its variants instead. #5075

	- Create a StreamMessage from Future: You can now easily create a <type://StreamMessage> from a <type://CompletionStage>
	- Create a StreamMessage from Future: You can now easily create a <type://StreamMessage> from a `CompletionStage`

	- Netty 4.1.95.Final → 4.1.96.Final
	- Netty 4.1.94.Final → 4.1.96.Final


		## 🌟 New features

		- GraalVM Support: You can now easily build [GraalVM](https://www.graalvm.org/) native images for Armeria applications. #5005

	- GraalVM Support: You can now easily build [GraalVM](https://www.graalvm.org/) native images for Armeria applications. #5005
	- GraalVM Support: Armeria now provides [GraalVM](https://www.graalvm.org/) [reachability metadata](https://www.graalvm.org/latest/reference-manual/native-image/metadata/) to easily build [GraalVM](https://www.graalvm.org/) native images. #5005

Add release notes for 1.25.0 #5114

Add release notes for 1.25.0 #5114

Conversation

jrhee17 commented Aug 15, 2023 • edited Loading

codecov bot commented Aug 15, 2023 • edited Loading

Codecov Report

github-actions bot commented Aug 21, 2023 • edited Loading

🔍 Build Scan® (commit: 1f6d69b)

minwoox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ikhoon Aug 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trustin left a comment

Choose a reason for hiding this comment

ikhoon left a comment

Choose a reason for hiding this comment

trustin left a comment

Choose a reason for hiding this comment

jrhee17 commented Aug 15, 2023 •

edited

Loading

codecov bot commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 21, 2023 •

edited

Loading

🔍 Build Scan® (commit: `1f6d69b`)

ikhoon Aug 22, 2023 •

edited

Loading