Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax validation for responses with empty content status. #5862

Merged
merged 3 commits into from
Aug 9, 2024

Merge branch 'main' into content_empty

6020bd4
Select commit
Loading
Failed to load commit list.
Merged

Relax validation for responses with empty content status. #5862

Merge branch 'main' into content_empty
6020bd4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 8, 2024 in 1s

74.61% (+0.04%) compared to c7aca10

View this Pull Request on Codecov

74.61% (+0.04%) compared to c7aca10

Details

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.61%. Comparing base (c7aca10) to head (6020bd4).
Report is 4 commits behind head on main.

Files Patch % Lines
...java/com/linecorp/armeria/common/HttpResponse.java 16.66% 4 Missing and 1 partial ⚠️
...om/linecorp/armeria/common/HttpResponseWriter.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5862      +/-   ##
============================================
+ Coverage     74.57%   74.61%   +0.04%     
- Complexity    21643    21693      +50     
============================================
  Files          1893     1896       +3     
  Lines         80153    80383     +230     
  Branches      10523    10575      +52     
============================================
+ Hits          59772    59980     +208     
- Misses        15341    15344       +3     
- Partials       5040     5059      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.