Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: com.linecorp.armeria.server.ServerBuilderTest.contextHook() #5877

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

my4-dev
Copy link
Contributor

@my4-dev my4-dev commented Aug 17, 2024

Motivation:

#5769

Modifications:

  • Added tearDown method with @AfterEach in order to reset each count variables used in tests

When executing this test in my local env, this test succeeded and I wasn't sure why this test failure was caused.
But, after adding this tearDown method, we will be able to avoid inappropriate variables staying in cnt variables.

Result:

@github-actions github-actions bot added the Stale label Sep 17, 2024
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of whether this fixes the actual flakiness, I agree that shared variables should be reset to avoid dependencies between tests. Thanks 👍

Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @my4-dev!

@github-actions github-actions bot removed the Stale label Sep 20, 2024
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@minwoox minwoox merged commit 326e747 into line:main Sep 23, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: com.linecorp.armeria.server.ServerBuilderTest.contextHook()
4 participants