Introduce rawPath in RequestTarget #5932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzfeng2020
changed the title
yzfeng2020
commented
Oct 2, 2024
| @@ -645,7 +654,9 @@ private static RequestTarget slowForClient(String reqTarget, | |||
| null, | |||
| -1, | |||
| encodedPath, | |||
| encodedPath, encodedQuery, | |||
| encodedPath, | |||
| encodedPath, | |||
There was a problem hiding this comment.
tbh I am not sure what's the best behavior for client, I just reuse the encodedPath
yzfeng2020
commented
Oct 2, 2024
| @@ -169,6 +169,7 @@ default RoutingContext withPath(String path) { | |||
| oldReqTarget.port(), | |||
| pathWithoutMatrixVariables, | |||
| path, | |||
| path, | |||
There was a problem hiding this comment.
same here, it seems like it's only going to modify the path but not query or fragment.
yzfeng2020
commented
Oct 2, 2024
| @@ -443,6 +451,7 @@ private static RequestTarget slowForServer(String reqTarget, boolean allowSemico | |||
| -1, | |||
| matrixVariablesRemovedPath, | |||
| encodedPath, | |||
| reqTarget, | |||
There was a problem hiding this comment.
my read of the code is that the reqTarget here is the original one in Http2RequestDecoder but it actually may be modified at Http1RequestDecoder.
|
hoping to get some feedbacks! |
yzfeng2020
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It may be useful if we have access to the original request path unmodified. For example we have use cases where the decoding rules are different from the ones at
decodedPath.Modifications:
Result: