-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid setting default Content-Type in content methods without explicit MediaType #5964
Open
JiwonKKang
wants to merge
3
commits into
line:main
Choose a base branch
from
JiwonKKang:duplicated_content_type_header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiwonKKang
requested review from
ikhoon,
jrhee17,
minwoox and
trustin
as code owners
October 30, 2024 07:07
JiwonKKang
changed the title
Avoid setting default Content-Type in
Avoid setting default Content-Type in content methods without explicit MediaType
Oct 30, 2024
content(String)
jrhee17
reviewed
Nov 4, 2024
@@ -50,6 +50,7 @@ protected void configure(ServerBuilder sb) { | |||
return HttpResponse.builder() | |||
.ok() | |||
.content("OK\n") | |||
.header(HttpHeaderNames.CONTENT_TYPE, "text/plain; charset=utf-8") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can simply alter the behavior since it can result in breaking changes like seen in the tests.
Rather, I think a more reasonable approach would be:
- Remember if a
String
content has been set for a request/response - At build time, if a content-type hasn't been set, set
text/plain
as the content-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
content-type
in response headers #5949HttpResponse could generate duplicate Content-Type headers if a user manually added a Content-Type header after setting the content with content(String). This can cause client errors or unexpected behavior when parsing the response.
Modifications:
Result: