Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CorsPolicyBuilder#build #6121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Feb 25, 2025

Motivation:

ref: https://discord.com/channels/1087271586832318494/1087272728177942629/1341502341517545585

Modifications:

  • Exposed the build method and added a test located in a different package

Result:

  • CorsPolicyBuilder#build is exposed publicly again

@jrhee17 jrhee17 added the defect label Feb 25, 2025
@jrhee17 jrhee17 added this to the 1.32.0 milestone Feb 25, 2025
@jrhee17 jrhee17 marked this pull request as ready for review February 25, 2025 07:26
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants