Fix wrong call depth in TomcatService.forCurrentClassPath() #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When a user calls TomcatService.forCurrentClassPath(), the caller class is determined to be TomcatService instead of the actual caller class. Modification: Increase the call depth parameter from 2 to 3 Result: TomcatService.forCurrentClassPath() works as expected.
|
Thanks. LGTM. |
delegacy
added a commit
that referenced
this pull request
Dec 22, 2015
Fix wrong call depth in TomcatService.forCurrentClassPath()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When a user calls TomcatService.forCurrentClassPath(), the caller class
is determined to be TomcatService instead of the actual caller class.
Modification:
Increase the call depth parameter from 2 to 3
Result:
TomcatService.forCurrentClassPath() works as expected.