Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a port number of remoteUrl in the mirror UI #1073

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Dec 11, 2024

Motivation:

I found that the port number of a remote URI was missing and wasn't shown in the mirror UI.

Modifications:

  • Use URI.getAuthority() to include the port number of a remote URI.

Result:

The custom port number of a remote URI is correctly displayed in the mirror UI.

Motivation:

I found that the port number of the remote URI was missing and was shown
in the mirror UI.

Modifications:

- Use `URI.getAuthority()` to include the port number of a remote URI.

Result:

The custom port number of a remote URI is correctly displayed in the mirror UI.
@ikhoon ikhoon added the defect label Dec 11, 2024
@ikhoon ikhoon added this to the 0.72.0 milestone Dec 11, 2024
Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@minwoox minwoox modified the milestones: 0.72.0, 0.73.0 Dec 16, 2024
@minwoox minwoox merged commit c134be1 into line:main Dec 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants