Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #686

Merged
merged 6 commits into from
Mar 29, 2022
Merged

Update dependencies #686

merged 6 commits into from
Mar 29, 2022

Conversation

jrhee17
Copy link
Contributor

@jrhee17 jrhee17 commented Mar 28, 2022

com.fasterxml.jackson:jackson-bom: 2.13.1 -> 2.13.2
com.linecorp.armeria:armeria-bom: 1.14.1 -> 1.15.0
io.micrometer:micrometer-bom: 1.8.2 -> 1.8.4
ch.qos.logback:logback-classic: 1.2.10 -> 1.2.11
com.github.node-gradle:gradle-node-plugin: 3.1.1 -> 3.2.1
com.google.guava: 31.0.1-jre -> 31.1-jre
com.puppycrawl.tools:checkstyle: 9.2.1 -> 10.1
net.javacrumbs.json-unit: 2.28.0 -> 2.32.0'
org.awaitility.awaitility: 4.1.1 -> 4.2.0
org.hibernate.validator:hibernate-validator: 6.1.6.Final -> 6.2.3.Final
org.mockito: 4.3.1 -> 4.4.0
org.slf4j: 1.7.35 -> 1.7.36
org.springframework.boot: 2.6.3 -> 2.6.5

dependencies.yml Outdated Show resolved Hide resolved
dependencies.yml Outdated
@@ -114,6 +114,7 @@ com.linecorp.armeria:
- https://www.javadoc.io/doc/com.linecorp.armeria/armeria-javadoc/1.14.1/

com.puppycrawl.tools:
# Requires jdk 11
checkstyle: { version: '9.2.1' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we disable checkstyle task if the build JDK is 8?

run: ./gradlew --no-daemon --stacktrace -Pcoverage checkstyle check build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a separate task to run on jdk 14 only 🙏

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #686 (7c88d10) into master (404db70) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 7c88d10 differs from pull request most recent head 4630ea7. Consider uploading reports for the commit 4630ea7 to get more accurate results

@@             Coverage Diff              @@
##             master     #686      +/-   ##
============================================
+ Coverage     70.12%   70.15%   +0.02%     
- Complexity     3413     3414       +1     
============================================
  Files           349      349              
  Lines         13468    13468              
  Branches       1454     1454              
============================================
+ Hits           9444     9448       +4     
+ Misses         3139     3136       -3     
+ Partials        885      884       -1     
Impacted Files Coverage Δ
...centraldogma/server/internal/api/WatchService.java 72.88% <0.00%> (-6.78%) ⬇️
...al/storage/repository/cache/CachingRepository.java 94.53% <0.00%> (-0.79%) ⬇️
...raldogma/server/internal/api/ContentServiceV1.java 85.07% <0.00%> (-0.75%) ⬇️
.../linecorp/centraldogma/client/AbstractWatcher.java 80.79% <0.00%> (+1.32%) ⬆️
...r/internal/admin/auth/FileBasedSessionManager.java 77.69% <0.00%> (+1.43%) ⬆️
...ient/armeria/legacy/LegacyCentralDogmaBuilder.java 85.18% <0.00%> (+3.70%) ⬆️
...ogma/client/armeria/CentralDogmaEndpointGroup.java 60.71% <0.00%> (+7.14%) ⬆️
...server/internal/thrift/CentralDogmaExceptions.java 63.63% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404db70...4630ea7. Read the comment docs.

@jrhee17
Copy link
Contributor Author

jrhee17 commented Mar 28, 2022

./gradlew dependencyUpdates
...
The following dependencies have later release versions:
 - com.bmuschko:gradle-docker-plugin [6.7.0 -> 7.3.0]
 - com.cronutils:cron-utils [5.0.5 -> 9.1.6]
     http://cron-parser.com/
 - com.fasterxml.jackson:jackson-bom [2.13.2 -> 2.13.2.20220324]
     https://github.com/FasterXML/jackson-bom
 - com.github.ben-manes.caffeine:caffeine [2.9.1 -> 3.0.6]
     https://github.com/ben-manes/caffeine
 - com.guardsquare:proguard-gradle [7.2.0 -> 7.2.1]
     https://www.guardsquare.com/proguard
 - com.jayway.jsonpath:json-path [2.2.0 -> 2.7.0]
     https://github.com/jayway/JsonPath
 - org.apache.curator:curator-recipes [4.3.0 -> 5.2.1]
     http://curator.apache.org
 - org.apache.curator:curator-test [4.3.0 -> 5.2.1]
     http://curator.apache.org
 - org.apache.shiro:shiro-core [1.3.2 -> 1.9.0]
     https://shiro.apache.org/
 - org.apache.thrift:libthrift [0.9.3 -> 0.16.0]
     http://thrift.apache.org
 - org.apache.zookeeper:zookeeper [3.5.8 -> 3.8.0]
     http://zookeeper.apache.org
 - org.eclipse.jgit:org.eclipse.jgit [5.13.0.202109080827-r -> 6.1.0.202203080745-r]
     ${jgit-url}
 - org.eclipse.jgit:org.eclipse.jgit.ssh.jsch [5.13.0.202109080827-r -> 6.1.0.202203080745-r]
     ${jgit-url}
 - org.hibernate.validator:hibernate-validator [6.2.3.Final -> 7.0.4.Final]
     http://hibernate.org/validator

Gradle release-candidate updates:
 - Gradle: [6.8.3 -> 7.4.1]

@jrhee17
Copy link
Contributor Author

jrhee17 commented Mar 28, 2022

Guardsquare/proguard#231

Unsure why armeria side passed, but let me leave proguard without updates

@jrhee17 jrhee17 force-pushed the 0.56.0-deps branch 2 times, most recently from ad80e14 to 1925eae Compare March 28, 2022 07:46
@jrhee17 jrhee17 marked this pull request as ready for review March 28, 2022 09:32
@jrhee17 jrhee17 requested review from minwoox and trustin as code owners March 28, 2022 09:32
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jrhee17!

@ikhoon
Copy link
Contributor

ikhoon commented Mar 29, 2022

Note: Flaky tests really harass the CI results. We may need to split flaky tests from core tests and add separate builds like we did in Armeria.

@ikhoon ikhoon added this to the 0.55.1 milestone Mar 29, 2022
@ikhoon ikhoon merged commit d72070e into line:master Mar 29, 2022
@jrhee17 jrhee17 deleted the 0.56.0-deps branch March 29, 2022 01:58
@jrhee17 jrhee17 modified the milestones: 0.55.1, 0.56.0 Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants