-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #686
Update dependencies #686
Conversation
dependencies.yml
Outdated
@@ -114,6 +114,7 @@ com.linecorp.armeria: | |||
- https://www.javadoc.io/doc/com.linecorp.armeria/armeria-javadoc/1.14.1/ | |||
|
|||
com.puppycrawl.tools: | |||
# Requires jdk 11 | |||
checkstyle: { version: '9.2.1' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we disable checkstyle
task if the build JDK is 8?
centraldogma/.github/workflows/gradle.yml
Line 51 in 2ee824a
run: ./gradlew --no-daemon --stacktrace -Pcoverage checkstyle check build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a separate task to run on jdk 14 only 🙏
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
============================================
+ Coverage 70.12% 70.15% +0.02%
- Complexity 3413 3414 +1
============================================
Files 349 349
Lines 13468 13468
Branches 1454 1454
============================================
+ Hits 9444 9448 +4
+ Misses 3139 3136 -3
+ Partials 885 884 -1
Continue to review full report at Codecov.
|
|
Unsure why armeria side passed, but let me leave |
ad80e14
to
1925eae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jrhee17!
Note: Flaky tests really harass the CI results. We may need to split flaky tests from core tests and add separate builds like we did in Armeria. |
com.fasterxml.jackson:jackson-bom: 2.13.1 -> 2.13.2
com.linecorp.armeria:armeria-bom: 1.14.1 -> 1.15.0
io.micrometer:micrometer-bom: 1.8.2 -> 1.8.4
ch.qos.logback:logback-classic: 1.2.10 -> 1.2.11
com.github.node-gradle:gradle-node-plugin: 3.1.1 -> 3.2.1
com.google.guava: 31.0.1-jre -> 31.1-jre
com.puppycrawl.tools:checkstyle: 9.2.1 -> 10.1
net.javacrumbs.json-unit: 2.28.0 -> 2.32.0'
org.awaitility.awaitility: 4.1.1 -> 4.2.0
org.hibernate.validator:hibernate-validator: 6.1.6.Final -> 6.2.3.Final
org.mockito: 4.3.1 -> 4.4.0
org.slf4j: 1.7.35 -> 1.7.36
org.springframework.boot: 2.6.3 -> 2.6.5