Close an SSH session when an auth fails #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: An SSH session wasn't closed when an exception is raised while calling `session.auth()` Modification: - Close an SSH session when an exception is raised while calling `session.auth()` Result: - An SSH session is closed even an exception is raised while calling `sesison.auth()`
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
============================================
- Coverage 65.93% 65.89% -0.05%
+ Complexity 3373 3369 -4
============================================
Files 360 360
Lines 14025 14020 -5
Branches 1505 1502 -3
============================================
- Hits 9248 9238 -10
- Misses 3918 3924 +6
+ Partials 859 858 -1
☔ View full report in Codecov by Sentry. |
ikhoon
approved these changes
Sep 15, 2023
jrhee17
approved these changes
Sep 25, 2023
| throw new RuntimeException(e); | ||
| } catch (Throwable t) { | ||
| if (session != null) { | ||
| session.close(true); |
There was a problem hiding this comment.
Understood that this is the actual point that is expected to fix the start/stop logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
An SSH session wasn't closed when an exception was raised while calling
session.auth()Modification:
session.auth()Result:
sesison.auth()