Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gradle 8 support #103

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Add Gradle 8 support #103

merged 3 commits into from
Jun 26, 2024

Conversation

PirateBrook
Copy link
Contributor

related issue: #101

@CLAassistant
Copy link

CLAassistant commented Jun 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@onevcat onevcat requested a review from YkSix June 14, 2024 02:47
@onevcat
Copy link
Member

onevcat commented Jun 14, 2024

@YkSix Can you check and see if this is necessary or might bring any side effect? Thanks!

YkSix
YkSix reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@YkSix YkSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.

All the code changes related to the example app look good to me. However, I have concerns about setting a higher version at the SDK level. Please take a look at my comments.
Thanks.

android/build.gradle Outdated Show resolved Hide resolved
android/build.gradle Outdated Show resolved Hide resolved
android/gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
YkSix
YkSix reviewed Jun 25, 2024
View reviewed changes
android/build.gradle Outdated Show resolved Hide resolved
@PirateBrook @YkSix
Update android/build.gradle
2dbb3fa 
fix: Adjust low version compatibility

Co-authored-by: Eric Lu <yksix0702@gmail.com>
@PirateBrook
Copy link
Contributor Author

@YkSix Thanks for your reminder, I overlooked the unupdated projects

@YkSix
Copy link
Contributor

YkSix commented Jun 25, 2024

@PirateBrook ,
Thanks for your efforts.
Could you please update the ext.kotlin_version to 1.7.21, the AGP to 7.3.1, and Gradle to version 7.6 if it sounds good to you?
Thanks.

@PirateBrook
Copy link
Contributor Author

@YkSix
It's works for my project, thanks for help.

YkSix
YkSix approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@YkSix YkSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for @PirateBrook 's efforts.

@YkSix YkSix merged commit 138736b into line:master Jun 26, 2024
2 checks passed
@onevcat onevcat mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YkSix YkSix YkSix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PirateBrook @CLAassistant @onevcat @YkSix