Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude lifecycle-extensions #94

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Exclude lifecycle-extensions #94

merged 1 commit into from
Mar 18, 2024

Conversation

amlzq
Copy link
Contributor

@amlzq amlzq commented Feb 6, 2024

Fix #93

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@onevcat onevcat requested a review from YkSix February 6, 2024 08:59
@onevcat
Copy link
Member

onevcat commented Feb 6, 2024

@YkSix Do you have a chance to take a look at this and the reason explained in #93?

I am not sure whether this is required in the current LINE SDK flutter.

YkSix
YkSix approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@YkSix YkSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onevcat onevcat merged commit 787abd4 into line:master Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YkSix YkSix YkSix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not find androidx.lifecycle:lifecycle-extensions:2.5.0.
4 participants
@amlzq @CLAassistant @onevcat @YkSix