feat: implement validateGasWanted() (#48)
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: impl `validateGasWanted()` * fix: lint error * chore: bump up tendermint * fix: tests to use `grpc` instead of `socket` # Conflicts: # go.mod # go.sum # server/start.go # x/genutil/client/cli/init_test.go
wetcod
approved these changes
Apr 22, 2021
egonspace
approved these changes
Apr 22, 2021
brew0722
pushed a commit
that referenced
this pull request
Apr 26, 2021
Add genesis ex-/import for `lastContractId` sequence
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: line/lbm#1262
Cherry-pick: #48
Description
Validate
GasWantedduringante handler. It's need to remove tendermint mempool.postCheck().It should reconstruct the same logic with https://github.com/line/tendermint/blob/a01efd28c7257d3b056d1fcf263d39ccea3c1273/mempool/mempool.go#L126
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes