-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check bech32 address format in bank query #366
fix: check bech32 address format in bank query #366
Conversation
Codecov Report
@@ Coverage Diff @@
## release/v0.43.x #366 +/- ##
==================================================
Coverage ? 53.17%
==================================================
Files ? 642
Lines ? 67259
Branches ? 0
==================================================
Hits ? 35763
Misses ? 28551
Partials ? 2945 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it okay if everything in changelog.md deleted?
RELEASE_CHANGELOG.md
Outdated
## [v0.43.1](https://github.com/line/lbm-sdk/releases/tag/v0.43.1) | ||
|
||
### Bug Fixes | ||
* (distribution) [\#364](https://github.com/line/lbm-sdk/pull/364) Emit error in tx withdraw-all-rewards when the signer has no delegations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* (distribution) [\#364](https://github.com/line/lbm-sdk/pull/364) Emit error in tx withdraw-all-rewards when the signer has no delegations | |
* (distribution) [\#364](https://github.com/line/lbm-sdk/pull/364) Force genOrBroadcastFn even when max-msgs != 0 |
I've updated the title of my PR. Sorry for the interrupt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll apply it.
Yes. I intended that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: check bech32 address format in bank query * docs: modify release_changelog; wrong PR number * docs: modify release changelog
* docs: update changelog * docs: update release_changelog * fix: check bech32 address format in bank query (#366) * fix: check bech32 address format in bank query * docs: modify release_changelog; wrong PR number * docs: modify release changelog * ci: add auto pr * ci: enable long sim test for release branch * fix: merge main files * docs: update changelog, release_changelog
Description
closes: #362
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes