Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check bech32 address format in bank query #366

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

egonspace
Copy link

Description

closes: #362


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Sorry, something went wrong.

@egonspace egonspace self-assigned this Nov 1, 2021
@egonspace egonspace added the A: bug Something isn't working label Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.43.x@bae3a4c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/v0.43.x     #366   +/-   ##
==================================================
  Coverage                   ?   53.17%           
==================================================
  Files                      ?      642           
  Lines                      ?    67259           
  Branches                   ?        0           
==================================================
  Hits                       ?    35763           
  Misses                     ?    28551           
  Partials                   ?     2945           

Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it okay if everything in changelog.md deleted?

## [v0.43.1](https://github.com/line/lbm-sdk/releases/tag/v0.43.1)

### Bug Fixes
* (distribution) [\#364](https://github.com/line/lbm-sdk/pull/364) Emit error in tx withdraw-all-rewards when the signer has no delegations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* (distribution) [\#364](https://github.com/line/lbm-sdk/pull/364) Emit error in tx withdraw-all-rewards when the signer has no delegations
* (distribution) [\#364](https://github.com/line/lbm-sdk/pull/364) Force genOrBroadcastFn even when max-msgs != 0

I've updated the title of my PR. Sorry for the interrupt.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll apply it.

@egonspace
Copy link
Author

Is it okay if everything in changelog.md deleted?

Yes. I intended that CHANGELOG of a release branch contains empty.

Copy link
Contributor

@iproudhon iproudhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit 68d1b1c into Finschia:release/v0.43.x Nov 1, 2021
egonspace pushed a commit that referenced this pull request Nov 2, 2021
* fix: check bech32 address format in bank query

* docs: modify release_changelog; wrong PR number

* docs: modify release changelog
egonspace pushed a commit that referenced this pull request Nov 2, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* docs: update changelog

* docs: update release_changelog

* fix: check bech32 address format in bank query (#366)

* fix: check bech32 address format in bank query

* docs: modify release_changelog; wrong PR number

* docs: modify release changelog

* ci: add auto pr

* ci: enable long sim test for release branch

* fix: merge main files

* docs: update changelog, release_changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants