feat: detaching StoreCodeAndInstantiateContract from wasm's tx.proto #625
+4,307
−2,532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Codecov Report
@@ Coverage Diff @@
## feat/wasm_refactor #625 +/- ##
======================================================
+ Coverage 60.19% 60.45% +0.25%
======================================================
Files 817 825 +8
Lines 94971 95654 +683
======================================================
+ Hits 57169 57827 +658
- Misses 34329 34370 +41
+ Partials 3473 3457 -16
|
…m/wasm/v1`. Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
dudong2
reviewed
Aug 8, 2022
tnasu
reviewed
Aug 9, 2022
tnasu
reviewed
Aug 9, 2022
| @@ -135,18 +135,6 @@ message UnpinCodesProposal { | |||
| repeated uint64 code_ids = 3 [(gogoproto.customname) = "CodeIDs", (gogoproto.moretags) = "yaml:\"code_ids\""]; | |||
| } | |||
|
|
|||
| // UpdateStatusProposal gov proposal content type to update the contract status. | |||
| message UpdateContractStatusProposal { | |||
There was a problem hiding this comment.
Yes, this proposal's role is to modify the smart contract as inactive or active. This is the one of contract blacklist functions. I'll add the contract blacklist function through another PR.
There was a problem hiding this comment.
Does it mean that the blacklist functions will replace the msg we previously added on our own?
There was a problem hiding this comment.
@shiki-tak , Yes, I'll have a plan to add the contract blacklist data in the genesisState. So I'll add it to sixth index in the genesisState like below.
message GenesisState {
….
// GenMsgs has wasmd sdk type messages to execute in the genesis phase
repeated cosmwasm.wasm.v1.GenesisState.GenMsgs gen_msgs = 5 [(gogoproto.nullable) = false, (gogoproto.jsontag) = "gen_msgs,omitempty"];
// InactiveContractAddresses is a list of contract address that set inactive
repeated string inactive_contract_addresses = 6 [(gogoproto.jsontag) = "inactive_contract_address, omitempty"];
}In this case, the contract blacklist are saved in the genesisState, and when every contract is executed, it is checked if it is blacklist contract or not. it is a little difference with current checking system.
Co-authored-by: Sujong Lee <leesj9476lsj@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
reviewed
Aug 11, 2022
Signed-off-by: zemyblue <zemyblue@gmail.com>
tnasu
approved these changes
Aug 16, 2022
loloicci
approved these changes
Aug 17, 2022
5 tasks
This was referenced May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related: #623
Detach custom changes proto from original cosmwasm proto
Detach custom proto change in
cosmwasm/wasm/v1/StoreCodeAndInstantiateContractfromcosmwasm/wasm/v1/tx.prototolbm/wasm/v1/tx.protoUpdateContractStatusProposalfromcosmwasm/wasm/v1/proposal.prototolbm/wasm/v1/proposal.protoContractStatustype fromcosmwasm/wasm/v1/types.protptolbm/wasm/v1/types.protoChange to original type
gas_multiplier,instance_costandcompile_costofParamsincosmwasm/wasm/v1/types.proto. And create newParamsfor lbm's genesis tolbm/wasm/v1/types.protostatusofContractInfoincosmwasm/wasm/v1/types.protoAdd new genesis proto in
lbm/wasm/v1/Remove custom contract blacklist function
This contract blacklist function will be added through another PR.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml