Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change data api's domain to api-data.line.me #178

Merged
merged 3 commits into from
Dec 9, 2019
Merged

fix: change data api's domain to api-data.line.me #178

merged 3 commits into from
Dec 9, 2019

Conversation

xingoxu
Copy link
Member

@xingoxu xingoxu commented Nov 19, 2019

fix #176

@tkgauri tkgauri requested a review from ianwith November 26, 2019 07:04
ianwith
ianwith reviewed Nov 27, 2019
View reviewed changes
package.json Outdated
@@ -23,6 +23,7 @@
"docs": "vuepress dev docs",
"docs:build": "vuepress build docs",
"docs:deploy": "./deploy-docs.sh",
"prepublish": "npm run build",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is exactly the same as pretest

ianwith
ianwith reviewed Nov 27, 2019
View reviewed changes
lib/endpoints.ts Outdated
OAUTH_BASE_URL = `${TEST_SERVER}/oauth`;
} else {
MESSAGING_API_HOST = `https://api.line.me/v2/bot`;
DATA_HOST = `https://api-data.line.me/v2/bot`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATA_HOST MESSAGING_API_HOST
maybe they should be DATA_API_URL MESSAGING_API_URL, instead of HOST. Consider to make it in line with OAUTH_BASE_URL

@xingoxu xingoxu mentioned this pull request Dec 8, 2019
Merged
ianwith
ianwith approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@ianwith ianwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingoxu xingoxu merged commit 6445ac8 into line:master Dec 9, 2019
@xingoxu xingoxu deleted the fix-176 branch December 9, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianwith ianwith ianwith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Domain name change from api.line.me to api-data.line.me
2 participants
@xingoxu @ianwith